Allow users to overwrite ld with environment variable in linker optimization script (#137331)

hmaarrfk · pytorchmergebot · commit 43afaa4aac16 · 2024-11-26T22:54:24.000Z
This should help in the case of cross compilation. xref: conda-forge/pytorch-cpu-feedstock#261 Fixes #ISSUE_NUMBER Pull Request resolved: #137331 Approved by: https://github.com/isuruf, https://github.com/seemethere
diff --git a/tools/setup_helpers/generate_linker_script.py b/tools/setup_helpers/generate_linker_script.py
@@ -1,3 +1,4 @@
+import os
 import subprocess
 
 
@@ -9,8 +10,8 @@ def gen_linker_script(
         prioritized_text = [
             line.replace("\n", "") for line in prioritized_text if line != "\n"
         ]
-
-    linker_script_lines = subprocess.check_output(["ld", "-verbose"], text=True).split(
+    ld = os.environ.get("LD", "ld")
+    linker_script_lines = subprocess.check_output([ld, "-verbose"], text=True).split(
         "\n"
     )
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+import os`
`1`	`2`	`import subprocess`
`2`	`3`
`3`	`4`
`@@ -9,8 +10,8 @@ def gen_linker_script(`
`9`	`10`	`prioritized_text = [`
`10`	`11`	`line.replace("\n", "") for line in prioritized_text if line != "\n"`
`11`	`12`	`]`
`12`		`-`
`13`		`- linker_script_lines = subprocess.check_output(["ld", "-verbose"], text=True).split(`
	`13`	`+ ld = os.environ.get("LD", "ld")`
	`14`	`+ linker_script_lines = subprocess.check_output([ld, "-verbose"], text=True).split(`
`14`	`15`	`"\n"`
`15`	`16`	`)`
`16`	`17`