10000 Update base for Update on "Trace attention inference patterns with p=… · pytorch/pytorch@227e6da · GitHub
[go: up one dir, main page]
Skip to content

Commit 227e6da

Browse files
eellisoneellison
committed
Update base for Update on "Trace attention inference patterns with p=0, cleanup"
 When dropout is traced in inference, it creates a clone() instead of training pattern of rand() etc. This was partially addressed by manually #108141, however that did not cover all of the patterns that included dropout, and there is no reason we should have to specify them manually. This updates the inference patterns generated to trace with dropout_p = 0.0. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy ngimel yf225 chenyang78 kadeng muchulee8 aakhundov [ghstack-poisoned]
2 parents 4a4a2fc + e066056 commit 227e6da

File tree

194 files changed

+6947
-2457
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

194 files changed

+6947
-2457
lines changed

‎.ci/docker/ci_commit_pins/huggingface.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4.27.4
1+
6c26faa159b79a42d7fa46cb66e2d21523351987

‎.ci/docker/common/install_inductor_benchmark_deps.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ source "$(dirname "${BASH_SOURCE[0]}")/common_utils.sh"
66

77
function install_huggingface() {
88
local version
9-
version=$(get_pinned_commit huggingface)
9+
commit=$(get_pinned_commit huggingface)
1010
pip_install pandas==2.0.3
11-
pip_install "transformers==${version}"
11+
pip_install "git+https://github.com/huggingface/transformers@${commit}"
1212
}
1313

1414
function install_timm() {

‎.ci/docker/common/install_onnx.sh

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,9 @@ pip_install \
2929
transformers==4.32.1
3030

3131
pip_install coloredlogs packaging
32-
retry pip_install -i https://aiinfra.pkgs.visualstudio.com/PublicPackages/_packaging/ORT-Nightly/pypi/simple/ --no-cache-dir --no-input ort-nightly==1.16.0.dev20230824005
32+
retry pip_install -i https://aiinfra.pkgs.visualstudio.com/PublicPackages/_packaging/ORT-Nightly/pypi/simple/ --no-cache-dir --no-input ort-nightly==1.16.0.dev20230908001
3333

34-
# Using 1.15dev branch for the following not yet released features and fixes.
35-
# - Segfault fix for shape inference.
36-
# - Inliner to workaround ORT segfault.
37-
pip_install -i https://test.pypi.org/simple/ onnx==1.14.1rc2
38-
39-
# TODO: change this when onnx-script is on testPypi
34+
pip_install onnx==1.14.1
4035
pip_install onnxscript-preview==0.1.0.dev20230828 --no-deps
4136

4237
# Cache the transformers model to be used later by ONNX tests. We need to run the transformers

‎.ci/pytorch/win-test-helpers/test_libtorch.bat

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
:: Skip LibTorch tests when building a GPU binary and testing on a CPU machine
22
:: because LibTorch tests are not well designed for this use case.
3-
if "%USE_CUDA%" == "0" IF NOT "%CUDA_VERSION%" == "cpu" exit /b 0
3+
::if "%USE_CUDA%" == "0" IF NOT "%CUDA_VERSION%" == "cpu" exit /b 0
44

55
call %SCRIPT_HELPERS_DIR%\setup_pytorch_env.bat
66
if errorlevel 1 exit /b 1
@@ -34,17 +34,9 @@ set CPP_TESTS_DIR=%TMP_DIR_WIN%\build\torch\test
3434
:: Skip verify_api_visibility as it a compile level test
3535
if "%~1" == "verify_api_visibility" goto :eof
3636

37-
:: See https://github.com/pytorch/pytorch/issues/25161
38-
if "%~1" == "c10_metaprogramming_test" goto :eof
3937
if "%~1" == "module_test" goto :eof
4038
:: See https://github.com/pytorch/pytorch/issues/25312
4139
if "%~1" == "converter_nomigraph_test" goto :eof
42-
:: See https://github.com/pytorch/pytorch/issues/35636
43-
if "%~1" == "generate_proposals_op_gpu_test" goto :eof
44-
:: See https://github.com/pytorch/pytorch/issues/35648
45-
if "%~1" == "reshape_op_gpu_test" goto :eof
46-
:: See https://github.com/pytorch/pytorch/issues/35651
47-
if "%~1" == "utility_ops_gpu_test" goto :eof
4840

4941
echo Running "%~2"
5042
if "%~1" == "c10_intrusive_ptr_benchmark" (

‎.clang-tidy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ modernize-*,
4444
performance-*,
4545
readability-container-size-empty,
4646
'
47-
HeaderFilterRegex: '^(c10/(?!test)|torch/csrc/(?!deploy/interpreter/cpython)).*$'
47+
HeaderFilterRegex: '^(c10/(?!test)|torch/csrc/).*$'
4848
AnalyzeTemporaryDtors: false
4949
WarningsAsErrors: '*'
5050
...

‎.github/workflows/inductor-perf-compare.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
uses: ./.github/workflows/_linux-build.yml
1717
with:
1818
build-environment: linux-focal-cuda12.1-py3.10-gcc9-sm80
19-
docker-image-name: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-focal-cuda12.1-cudnn8-py3-gcc9-inductor-benchmarks:9dd361d1c04129f8eaa9d6b43335917800dd6d24
19+
docker-image-name: pytorch-linux-focal-cuda12.1-cudnn8-py3-gcc9-inductor-benchmarks
2020
cuda-arch-list: '8.0'
2121
test-matrix: |
2222
{ include: [

‎.github/workflows/inductor-perf-test-nightly.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
uses: ./.github/workflows/_linux-build.yml
6363
with:
6464
build-environment: linux-focal-cuda12.1-py3.10-gcc9-sm80
65-
docker-image-name: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-focal-cuda12.1-cudnn8-py3-gcc9-inductor-benchmarks:9dd361d1c04129f8eaa9d6b43335917800dd6d24
65+
docker-image-name: pytorch-linux-focal-cuda12.1-cudnn8-py3-gcc9-inductor-benchmarks
6666
cuda-arch-list: '8.0'
6767
test-matrix: |
6868
{ include: [

‎.github/workflows/inductor-periodic.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
uses: ./.github/workflows/_linux-build.yml
2121
with:
2222
build-environment: linux-focal-cuda12.1-py3.10-gcc9-sm86
23-
docker-image-name: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-focal-cuda12.1-cudnn8-py3-gcc9-inductor-benchmarks:9dd361d1c04129f8eaa9d6b43335917800dd6d24
23+
docker-image-name: pytorch-linux-focal-cuda12.1-cudnn8-py3-gcc9-inductor-benchmarks
2424
cuda-arch-list: '8.6'
2525
test-matrix: |
2626
{ include: [

‎.github/workflows/inductor.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
uses: ./.github/workflows/_linux-build.yml
1919
with:
2020
build-environment: linux-focal-cuda12.1-py3.10-gcc9-sm86
21-
docker-image-name: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-focal-cuda12.1-cudnn8-py3-gcc9-inductor-benchmarks:9dd361d1c04129f8eaa9d6b43335917800dd6d24
21+
docker-image-name: pytorch-linux-focal-cuda12.1-cudnn8-py3-gcc9-inductor-benchmarks
2222
cuda-arch-list: '8.6'
2323
test-matrix: |
2424
{ include: [
@@ -52,7 +52,7 @@ jobs:
5252
uses: ./.github/workflows/_linux-build.yml
5353
with:
5454
build-environment: linux-focal-cuda12.1-py3.10-gcc9-sm80
55-
docker-image-name: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-focal-cuda12.1-cudnn8-py3-gcc9-inductor-benchmarks:9dd361d1c04129f8eaa9d6b43335917800dd6d24
55+
docker-image-name: pytorch-linux-focal-cuda12.1-cudnn8-py3-gcc9-inductor-benchmarks
5656
cuda-arch-list: '8.0'
5757
test-matrix: |
5858
{ include: [

‎.github/workflows/lint.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ jobs:
1717
lintrunner:
1818
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
1919
with:
20+
timeout: 120
2021
runner: linux.2xlarge
2122
docker-image: pytorch-linux-focal-linter
2223
fetch-depth: 0

0 commit comments

Comments
 (0)
0