Update fbgemm pinned version (#153072)

gchalump · facebook-github-bot · commit 160ccf0d8e9e · 2025-05-15T13:29:30.000-07:00
Summary: Pull Request resolved: #153072 Update fbgemm pinned version. Related update in fbgemm: D74434751 Included changes: - Update fbgemm external dependencies directory in setup.py Differential Revision: D74335570
diff --git a/WORKSPACE b/WORKSPACE
@@ -144,8 +144,8 @@ new_local_repository(
 
 new_local_repository(
     name = "asmjit",
-    build_file = "//third_party:fbgemm/third_party/asmjit.BUILD",
-    path = "third_party/fbgemm/third_party/asmjit",
+    build_file = "//third_party:fbgemm/external/asmjit.BUILD",
+    path = "third_party/fbgemm/external/asmjit",
 )
 
 new_local_repository(
diff --git a/setup.py b/setup.py
@@ -443,7 +443,7 @@ def not_exists_or_empty(folder):
             ],
         )
     check_for_files(
-        os.path.join(third_party_path, "fbgemm", "third_party", "asmjit"),
+        os.path.join(third_party_path, "fbgemm", "external", "asmjit"),
         ["CMakeLists.txt"],
     )
 
@@ -1154,6 +1154,11 @@ def main():
             os.getenv("CXXFLAGS", "") + " -ffunction-sections -fdata-sections"
         )
 
+    # Disable fbgemm auto-vectorization to prevent excessive library size, which requires symbol relocation only allowed in static libraries
+    os.environ["CXXFLAGS"] = (
+            os.getenv("CXXFLAGS", "") + " -DDISABLE_FBGEMM_AUTOVEC=ON"
+        )
+
     # Parse the command line and check the arguments before we proceed with
     # building deps and setup. We need to set values so `--help` works.
     dist = Distribution()
diff --git a/third_party/fbgemm b/third_party/fbgemm
@@ -1 +1 @@
-Subproject commit dbc3157bf256f1339b3fa1fef2be89ac4078be0e
+Subproject commit fa411c1a63916d76241b350e10629f9369f37d4d

Original file line number	Diff line number	Diff line change
`@@ -144,8 +144,8 @@ new_local_repository(`
`144`	`144`
`145`	`145`	`new_local_repository(`
`146`	`146`	`name = "asmjit",`
`147`		`- build_file = "//third_party:fbgemm/third_party/asmjit.BUILD",`
`148`		`- path = "third_party/fbgemm/third_party/asmjit",`
	`147`	`+ build_file = "//third_party:fbgemm/external/asmjit.BUILD",`
	`148`	`+ path = "third_party/fbgemm/external/asmjit",`
`149`	`149`	`)`
`150`	`150`
`151`	`151`	`new_local_repository(`
Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,7 @@ def not_exists_or_empty(folder):`
`443`	`443`	`],`
`444`	`444`	`)`
`445`	`445`	`check_for_files(`
`446`		`- os.path.join(third_party_path, "fbgemm", "third_party", "asmjit"),`
	`446`	`+ os.path.join(third_party_path, "fbgemm", "external", "asmjit"),`
`447`	`447`	`["CMakeLists.txt"],`
`448`	`448`	`)`
`449`	`449`
`@@ -1154,6 +1154,11 @@ def main():`
`1154`	`1154`	`os.getenv("CXXFLAGS", "") + " -ffunction-sections -fdata-sections"`
`1155`	`1155`	`)`
`1156`	`1156`
	`1157`	`+ # Disable fbgemm auto-vectorization to prevent excessive library size, which requires symbol relocation only allowed in static libraries`
	`1158`	`+ os.environ["CXXFLAGS"] = (`
	`1159`	`+ os.getenv("CXXFLAGS", "") + " -DDISABLE_FBGEMM_AUTOVEC=ON"`
	`1160`	`+ )`
	`1161`	`+`
`1157`	`1162`	`# Parse the command line and check the arguments before we proceed with`
`1158`	`1163`	# building deps and setup. We need to set values so `--help` works.
`1159`	`1164`	`dist = Distribution()`