Remove warnings on non-buffer tensor constants

tugsbayasgalan · tugsbayasgalan · commit 1268629a7bd8 · 2025-03-11T13:38:05.000-07:00
Pull Request resolved: #148483 cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @imported-using-ghimport Differential Revision: [D70577321](https://our.internmc.facebook.com/intern/diff/D70577321/) ghstack-source-id: 271094772
diff --git a/torch/fx/graph.py b/torch/fx/graph.py
@@ -1748,8 +1748,6 @@ def check_arg(arg: Node, n: Optional[Node] = None) -> None:
 
         # Check targets are legit
         if self.owning_module:
-            num_warnings = 0
-            MAX_WARNINGS = 5
             for node in self.nodes:
                 if node.op == "call_function":
                     if not callable(node.target):
@@ -1781,29 +1779,8 @@ def check_arg(arg: Node, n: Optional[Node] = None) -> None:
                                 f"Node {node} target {node.target} {atom} of {seen_qualname} does "
                                 "not reference an nn.Module"
                             )
-                        elif (
-                            node.op == "get_attr"
-                            and not isinstance(new_m_itr, torch.nn.Module)
-                            and not isinstance(new_m_itr, torch.nn.Parameter)
-                            and atom not in m_itr._buffers
-                        ):
-                            if num_warnings < MAX_WARNINGS:
-                                # Don't emit this warning too frequently,
-                                # for very large graphs this can become very expensive
-                                # from a performance perspective.
-                                warnings.warn(
-                                    f"Node {node} target {node.target} {atom} of {seen_qualname} does "
-                                    "not reference an nn.Module, nn.Parameter, or buffer, which is "
-                                    "what 'get_attr' Nodes typically target"
-                                )
-                            num_warnings += 1
-                        else:
-                            m_itr = new_m_itr
-            if num_warnings > MAX_WARNINGS:
-                warnings.warn(
-                    f"Additional {num_warnings - MAX_WARNINGS} warnings "
-                    "suppressed about get_attr references"
-                )
+
+                        m_itr = new_m_itr
 
     @compatibility(is_backward_compatible=True)
     def eliminate_dead_code(
