add comments for torch_cuda_linalg fixing.

xuhancn · xuhancn · commit 00d0a9b738c0 · 2025-02-27T16:13:11.000+08:00
remove debug log.
Work around MKL for CUDA.
diff --git a/cmake/Modules/FindMKL.cmake b/cmake/Modules/FindMKL.cmake
@@ -292,7 +292,6 @@ MACRO(CHECK_ALL_LIBRARIES LIBRARIES OPENMP_TYPE OPENMP_LIBRARY _name _list _flag
         SET(_found_tbb TRUE)
       ELSE()
         SET(lib_names ${_library})
-        message("!!!!! lib_names: ${lib_names}.${SHARED_SO_VERSION_NUM}")
         FIND_LIBRARY(${_prefix}_${_library}_LIBRARY NAMES ${lib_names} ${lib_names}.${SHARED_SO_VERSION_NUM})
       ENDIF()
       MARK_AS_ADVANCED(${_prefix}_${_library}_LIBRARY)
diff --git a/cmake/public/mkl.cmake b/cmake/public/mkl.cmake
@@ -23,8 +23,10 @@ set_property(
   ${MKL_ROOT}/lib ${MKL_ROOT}/lib/intel64 ${MKL_ROOT}/lib/intel64_win ${MKL_ROOT}/lib/win-x64)
 
 if(UNIX)
-  # if(USE_STATIC_MKL AND 0)
-  if(USE_STATIC_MKL)
+  # Disable it for it will caused torch_cuda_linalg link failed.
+  # Link: https://github.com/pytorch/pytorch/issues/146551#issuecomment-2655672240
+  # TODO: if torch_cuda_linalg USE mkl, need to find link mkl directly, but not torch_cpu.so.
+  if(USE_STATIC_MKL AND NOT USE_CUDA)
     foreach(MKL_LIB_PATH IN LISTS MKL_LIBRARIES)
       if(NOT EXISTS "${MKL_LIB_PATH}")
         continue()
diff --git a/test/custom_operator/CMakeLists.txt b/test/custom_operator/CMakeLists.txt
@@ -11,6 +11,7 @@ find_package(Torch REQUIRED)
 add_library(custom_ops SHARED op.cpp)
 set_property(TARGET custom_ops PROPERTY CXX_STANDARD 17)
 
+message("!!!!!!!!! TORCH_LIBRARIES: ${TORCH_LIBRARIES}")
 target_compile_features(custom_ops PUBLIC cxx_range_for)
 target_link_libraries(custom_ops "${TORCH_LIBRARIES}")
 target_compile_definitions(custom_ops PRIVATE custom_ops_EXPORTS)
