8000 Update on "[build] Add editable mode unittest" · pytorch/executorch@f5df1b3 · GitHub
[go: up one dir, main page]
Skip to content

Commit f5df1b3

Browse files
larryliu0820larryliu0820
committed
Update on "[build] Add editable mode unittest"
As titled. To do this we need to refactor the arguments being passed into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh` `unittest-macos.sh`. [ghstack-poisoned]
2 parents 443928e + bf8c120 commit f5df1b3

File tree

2 files changed

+0
-60
lines changed

2 files changed

+0
-60
lines changed

‎.github/workflows/pull.yml

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -56,30 +56,6 @@ jobs:
5656
# Build and test ExecuTorch with the add model on portable backend.
5757
PYTHON_EXECUTABLE=python bash .ci/scripts/test_model.sh "add" "${BUILD_TOOL}" "portable"
5858
59-
test-pip-install-editable-mode-linux:
60-
name: test-pip-install-editable-mode-linux
61-
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
62-
permissions:
63-
id-token: write
64-
contents: read
65-
strategy:
66-
fail-fast: false
67-
with:
68-
runner: linux.2xlarge
69-
docker-image: executorch-ubuntu-22.04-clang12
70-
submodules: 'true'
71-
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
72-
timeout: 90
73-
script: |
74-
# The generic Linux job chooses to use base env, not the one setup by the image
75-
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
76-
conda activate "${CONDA_ENV}"
77-
# Debug
78-
which pip
79-
PYTHON_EXECUTABLE=python bash ./install_executorch.sh --editable --pybind xnnpack --use-pt-pinned-commit
80-
# Try to import extension library
81-
python -c "from executorch.extension.llm.custom_ops import custom_ops"
82-
8359
test-models-linux:
8460
name: test-models-linux
8561
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
@@ -395,17 +371,6 @@ jobs:
395371
build-tool: cmake
396372
docker-image: executorch-ubuntu-22.04-clang12
397373

398-
unittest-editable:
399-
uses: ./.github/workflows/_unittest.yml
400-
permissions:
401-
id-token: write
402-
contents: read
403-
with:
404-
build-mode: Debug
405-
build-tool: cmake
406-
editable: true
407-
docker-image: executorch-ubuntu-22.04-clang12
408-
409374
unittest-buck:
410375
uses: ./.github/workflows/_unittest.yml
411376
permissions:

‎.github/workflows/trunk.yml

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -36,31 +36,6 @@ jobs:
3636
3737
PYTHONPATH="${PWD}" python .ci/scripts/gather_test_models.py --target-os macos --event "${GITHUB_EVENT_NAME}"
3838
39-
test-pip-install-editable-mode-macos:
40-
name: test-pip-install-editable-mode-macos
41-
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
42-
permissions:
43-
id-token: write
44-
contents: read
45-
strategy:
46-
fail-fast: false
47-
with:
48-
runner: macos-m1-stable
49-
python-version: '3.11'
50-
submodules: 'true'
51-
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
52-
timeout: 90
53-
script: |
54-
# The generic Linux job chooses to use base env, not the one setup by the image
55-
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
56-
conda activate "${C 6F12 ONDA_ENV}"
57-
# Debug
58-
which pip
59-
bash .ci/scripts/setup-conda.sh
60-
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash ./install_executorch.sh --editable --pybind xnnpack
61-
# Try to import extension library
62-
python -c "from executorch.extension.llm.custom_ops import custom_ops"
63-
6439
test-models-macos:
6540
name: test-models-macos
6641
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main

0 commit comments

Comments
 (0)
0