Drop preview header from reviews API call

omgjlk · omgjlk · commit efd164b861f7 · 2017-12-14T21:31:48.000-08:00
As of https://developer.github.com/changes/2017-05-09-end-black-cat-preview/ the reviews endpoint is no longer preview, and is now an official part of the API. It is no longer necessary to set a header when accessing this endpoint. Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -146,3 +146,5 @@ Contributors
 - Björn Kautler (@Vampire)
 
 - David Prothero (@dprothero)
+
+- Jesse Keating (@omgjlk)
diff --git a/github3/pulls.py b/github3/pulls.py
@@ -427,11 +427,8 @@ def reviews(self, number=-1, etag=None):
             endpoint
         :returns: generator of :class:`PullReview <PullReview>`\ s
         """
-        # Accept the preview headers for reviews
-        headers = {'Accept': 'application/vnd.github.black-cat-preview+json'}
         url = self._build_url('reviews', base_url=self._api)
-        return self._iter(int(number), url, PullReview, etag=etag,
-                          headers=headers)
+        return self._iter(int(number), url, PullReview, etag=etag)
 
     @requires_auth
     def update(self, title=None, body=None, state=None):
diff --git a/tests/unit/test_pulls.py b/tests/unit/test_pulls.py
@@ -243,7 +243,7 @@ def test_reviews(self):
         self.session.get.assert_called_once_with(
             url_for('reviews'),
             params={'per_page': 100},
-            headers={'Accept': 'application/vnd.github.black-cat-preview+json'}
+            headers={}
         )
 
 

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ def test_reviews(self):`
`243`	`243`	`self.session.get.assert_called_once_with(`
`244`	`244`	`url_for('reviews'),`
`245`	`245`	`params={'per_page': 100},`
`246`		`- headers={'Accept': 'application/vnd.github.black-cat-preview+json'}`
	`246`	`+ headers={}`
`247`	`247`	`)`
`248`	`248`
`249`	`249`