Merge pull request sigmavirus24#607 from bboe/json_encoding

sigmavirus24 · web-flow · commit bc3245eb554c · 2016-11-22T16:32:41.000-06:00
Fix serialization on Event objects.
diff --git a/github3/events.py b/github3/events.py
@@ -8,6 +8,8 @@
 """
 from __future__ import unicode_literals
 
+import copy
+
 from .models import GitHubCore
 
 
@@ -31,6 +33,10 @@ class Event(GitHubCore):
     """
 
     def _update_attributes(self, event):
+        # If we don't copy this, then we end up altering _json_data which we do
+        # not want to do:
+        event = copy.deepcopy(event)
+
         from .users import User
         from .orgs import Organization
         #: :class:`User <github3.users.User>` object representing the actor.
diff --git a/tests/integration/test_orgs.py b/tests/integration/test_orgs.py
@@ -117,6 +117,7 @@ def test_events(self):
 
             for event in o.events():
                 assert isinstance(event, github3.events.Event)
+                assert isinstance(event.as_json(), str)
 
     def test_members(self):
         """Test the ability to retrieve an organization's members."""
