Merge pull request sigmavirus24#658 from mindw/win32_test_fix

sigmavirus24 · web-flow · commit a334dbce0b94 · 2016-12-26T08:27:50.000-06:00
fix tests failures on Win32.
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -140,3 +140,5 @@ Contributors
 - Andreas Backx (@AndreasBackx)
 
 - Alexander Koshelev <daevaorn@gmail.com>
+
+- Gabi Davar (@mindw)
diff --git a/LATEST_VERSION_NOTES.rst b/LATEST_VERSION_NOTES.rst
@@ -5,6 +5,7 @@ Unreleased
 
 - Add ``Organization#all_events``.
 - Deprecate ``Organization#events`` in favor of ``Organization#public_events``.
+- Fix test failtures on windows caused by unclosed file handles.
 
 1.0.0a4: 2016-02-19
 ~~~~~~~~~~~~~~~~~~~
diff --git a/tests/integration/test_repos_release.py b/tests/integration/test_repos_release.py
@@ -135,7 +135,8 @@ def test_download(self):
             repository = self.gh.repository('sigmavirus24', 'github3.py')
             release = repository.release(76677)
             asset = next(release.assets())
-            _, filename = tempfile.mkstemp()
+            fd, filename = tempfile.mkstemp()
+            os.close(fd)
             asset.download(filename)
 
         with open(filename, 'rb') as fd:
@@ -153,7 +154,8 @@ def test_download_when_authenticated(self):
             repository = self.gh.repository('sigmavirus24', 'github3.py')
             release = repository.release(76677)
             asset = next(release.assets())
-            _, filename = tempfile.mkstemp()
+            fd, filename = tempfile.mkstemp()
+            os.close(fd)
             assert asset.session.auth is not None
             asset.download(filename)
             assert asset.session.auth is not None
