Be more concise and explicit in protection related tests.

bboe · bboe · commit 9aa1f003467e · 2015-11-15T09:28:06.000-08:00
diff --git a/tests/integration/test_repos_repo.py b/tests/integration/test_repos_repo.py
@@ -37,7 +37,7 @@ def test_branch(self):
             assert repository is not None
             branch = repository.branch('develop')
             assert isinstance(branch, github3.repos.branch.Branch)
-            assert branch.protection['enabled']
+            assert 'enabled' in branch.protection
 
     def test_branches(self):
         """Test the ability to retrieve the branches in a repository."""
@@ -54,11 +54,8 @@ def test_protected_branches(self):
         with self.recorder.use_cassette(cassette_name):
             repository = self.gh.repository('sigmavirus24', 'github3.py')
             assert repository is not None
-            found = False
-            for branch in repository.branches(protected=True):
-                assert branch.protection['enabled']
-                found = True
-            assert found
+            assert all(b.protection['enabled'] is True
+                       for b in repository.branches(protected=True))
 
     def test_code_frequency(self):
         """Test the ability to retrieve the code frequency in a repo."""
diff --git a/tests/test_repos.py b/tests/test_repos.py
@@ -85,7 +85,7 @@ def test_branch(self):
 
         b = self.repo.branch('master')
         assert isinstance(b, repos.branch.Branch)
-        assert b.protection
+        assert 'enabled' in b.protection
         self.mock_assertions()
 
         assert repr(b) == '<Repository Branch [master]>'
