8000 Update our notifications module to conform · pythonthings/github3.py@973435c · GitHub
[go: up one dir, main page]

Skip to content

Commit 973435c

Browse files
committed
Update our notifications module to conform
1 parent e65d27b commit 973435c

12 files changed

+272
-127
lines changed

LATEST_VERSION_NOTES.rst

Lines changed: 29 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,38 @@
33
Unreleased
44
~~~~~~~~~~
55

6+
Breaking Changes (since 1.0.0a4)
7+
````````````````````````````````
8+
9+
- Remove ``Thread.comment``, ``Thread.thread``, ``Thread.urls`` attributes.
10+
11+
- Remove ``Thread#is_unread`` method. Use the ``Thread.unread`` attribute
12+
instead.
13+
14+
- ``Subscription`` has been split into two objects: ``ThreadSubscription`` and
15+
``RepositorySubscription`` with the same methods.
16+
17+
- Remove ``is_ignored`` method from our Subscription objects. Use the
18+
``ignored`` attribute instead.
19+
20+
- Remove ``is_subscribed`` method from our Subscription objects. Use the
21+
``subscribed`` attribute instead.
22+
23+
Features Added (since 1.0.0a4)
24+
``````````````````````````````
25+
626
- Add ``Organization#all_events``.
7-
- Deprecate ``Organization#events`` in favor of ``Organization#public_events``.
8-
- Fix test failtures on windows caused by unclosed file handles.
27+
928
- Add ``Tag.tagger_as_User`` which attempts to return the tagger as as User.
29+
1030
- Add ``Repo.statuses`` and a corresponding ``repo.status.CombinedStatus`` to
31+
32+
Deprecations and Other Changes (since 1.0.0a4)
33+
``````````````````````````````````````````````
34+
35+
- Deprecate ``Organization#events`` in favor of ``Organization#public_events``.
36+
37+
- Fix test failtures on windows caused by unclosed file handles.
1138
get a combined view of commit statuses for a given ref.
1239

1340
1.0.0a4: 2016-02-19

github3/github.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@
2424
from .search import (CodeSearchResult, IssueSearchResult,
2525
RepositorySearchResult, UserSearchResult)
2626
from .structs import SearchIterator
27+
from . import notifications
2728
from . import orgs
2829
from . import users
29-
from .notifications import Thread
3030
from .licenses import License
3131
from uritemplate import URITemplate
3232

@@ -870,7 +870,7 @@ def notifications(self, all=False, participating=False, number=-1,
870870
:param str etag: (optional), ETag from a previous request to the same
871871
endpoint
872872
:returns: generator of
873-
:class:`Thread <github3.notifications.Thread>`
873+
:class:`~github3.notifications.Thread`
874874
"""
875875
params = None
876876
if all is True:
@@ -879,7 +879,9 @@ def notifications(self, all=False, participating=False, number=-1,
879879
params = {'participating': 'true'}
880880

881881
url = self._build_url('notifications')
882-
return self._iter(int(number), url, Thread, params, etag=etag)
882+
return self._iter(
883+
int(number), url, notifications.Thread, params, etag=etag
884+
)
883885

884886
def octocat(self, say=None):
885887
"""Returns an easter egg of the API.

0 commit comments

Comments
 (0)
0