Added additional attributes to Licenses

itsmemattchung · itsmemattchung · commit 7f41fca90b73 · 2015-11-13T17:02:19.000Z
Updated unit test for license to make sure attributes exist

Removed empty whiteline in repo.py
diff --git a/github3/licenses.py b/github3/licenses.py
@@ -34,5 +34,23 @@ def _update_attributes(self, license):
         # featured
         self.featured = license.get('featured')
 
+        # html url
+        self.html_url = license.get('html_url')
+
+        # body
+        self.body = license.get('body')
+
+        # key
+        self.key = license.get('key')
+
+        # description
+        self.description = license.get('description')
+
+        # implementation
+        self.implementation = license.get('implementation')
+
+        # required
+        self.required = license.get('required')
+
     def _repr(self):
         return '<License [{0}]>'.format(self.name)
diff --git a/github3/repos/repo.py b/github3/repos/repo.py
@@ -108,7 +108,6 @@ def _update_attributes(self, repo):
         self.id = repo.get('id', 0)
         #: Language property.
         self.language = repo.get('language', '')
-
         #: Mirror property.
         self.mirror_url = repo.get('mirror_url', '')
 
diff --git a/tests/unit/test_licenses.py b/tests/unit/test_licenses.py
@@ -14,6 +14,24 @@ class TestLicenses(UnitHelper):
     described_class = github3.licenses.License
     example_data = get_example_data()
 
+    def test_get_attr(self):
+        """Show that attributes exist in class."""
+        attributes = [
+            'description',
+            'body',
+            'implementation',
+            'html_url',
+            'key',
+            'required',
+            'name',
+            'permitted',
+            'category',
+            'forbidden',
+            'featured',
+        ]
+        for attr in attributes:
+            assert(getattr(self.instance, attr))
+
     def test_repr(self):
         """Show that instance string is formatted properly."""
         assert(repr(self.instance).startswith('<License'))
