Make Repository#create_file more defensive

sigmavirus24 · sigmavirus24 · commit 5c61661a7c5c · 2016-01-25T08:23:32.000-06:00
Do not mock the response from the API in unit tests
diff --git a/github3/repos/repo.py b/github3/repos/repo.py
@@ -743,7 +743,7 @@ def create_file(self, path, message, content, branch=None,
                     'author': validate_commmitter(author)}
             self._remove_none(data)
             json = self._json(self._put(url, data=dumps(data)), 201)
-            if 'content' in json and 'commit' in json:
+            if json and 'content' in json and 'commit' in json:
                 json['content'] = Contents(json['content'], self)
                 json['commit'] = Commit(json['commit'], self)
         return json
diff --git a/tests/unit/test_repos_repo.py b/tests/unit/test_repos_repo.py
@@ -78,9 +78,7 @@ def test_create_file(self):
             }
         }
 
-        with mock.patch.object(GitHubCore, '_json') as _json:
-            _json.return_value = create_file_contents_example_data
-            self.instance.create_file(**data)
+        self.instance.create_file(**data)
 
         b64_encoded_content = b64encode(data['content']).decode('utf-8')
         data.update({

Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,7 @@ def test_create_file(self):`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`
`81`		`- with mock.patch.object(GitHubCore, '_json') as _json:`
`82`		`- _json.return_value = create_file_contents_example_data`
`83`		`- self.instance.create_file(**data)`
	`81`	`+ self.instance.create_file(**data)`
`84`	`82`
`85`	`83`	`b64_encoded_content = b64encode(data['content']).decode('utf-8')`
`86`	`84`	`data.update({`