8000 Use correct attribute for pull request review ts · pythonthings/github3.py@4339db0 · GitHub
[go: up one dir, main page]

Skip to content

Commit 4339db0

Browse files
committed
Use correct attribute for pull request review ts
The timestamp for pull request reviews is 'submitted_at' instead of 'created_at' like most other objects. In addition, this attribute is not documented at https://developer.github.com/v3/pulls/reviews/#get-a-single-review Closes sigmavirus24#742 Signed-off-by: Jesse Keating <jkeating@j2solutions.net>
1 parent c82e90e commit 4339db0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

github3/pulls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ def _update_attributes(self, preview):
472472
self.state = self._get_attribute(preview, 'state')
473473

474474
#: datetime object representing when the event was created.
475-
self.created_at = self._strptime_attribute(preview, 'created_at')
475+
self.submitted_at = self._strptime_attribute(preview, 'submitted_at')
476476

477477
#: Body text of the review
478478
self.body = self._get_attribute(preview, 'body')

0 commit comments

Comments
 (0)
0