8000 Integrate review comments · pythonthings/github3.py@215f45f · GitHub
[go: up one dir, main page]
Skip to content

Commit 215f45f

Browse files
ueg1990ueg1990
committed
Integrate review comments
1 parent 6a58a4f commit 215f45f

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

‎AUTHORS.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,3 +112,5 @@ Contributors
112112
- Chris Thompson (@notyetsecure)
113113

114114
- Bastien Gandouet (@b4stien)
115+
116+
- Usman Ehtesham Gul (@ueg1990)

‎github3/repos/repo.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1653,8 +1653,11 @@ def release(self, id):
16531653
json = self._json(self._get(url), 200)
16541654
return self._instance_or_null(Release, json)
16551655

1656-
def release_by_tag_name(self, tag_name):
1657-
"""Get a relase by tag name
1656+
def release_from_tag(self, tag_name):
1657+
"""Get a release by tag name.
1658+
1659+
release_from_tag() returns a release with specified tag
1660+
while release() returns a release with specified release id
16581661
16591662
:param str tag_name: (required) name of tag
16601663
:returns: :class:`Release <github3.repos.release.Release>`

‎tests/cassettes/Repository_release_from_tag.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"http_interactions": [{"recorded_at": "2015-11-12T23:00:25", "response": {"body": {"encoding": "utf-8", "base64_string": "H4sIAAAAAAAAA62YTY+jOBCG/0rEddNxCOkvpNHMnnb3Nofey14iA06wGjCyTaI06v++r20gkNHmo71SK+oQ1+PX5SpT5TbgWRBHz+HyOQznQUVLFsTBjuu8SaJFfQzmwbYpik33g+K7ku65bNRqTSajxKFiMojboBA7XoExHgqKmWa1Xr5Ey3lA91RTuWlkgXG51rWKCXEP1cJRG8VkKirNKr1IRUka4oy/779FoO1kxzDYAA/OWDXvOM4YMEXOBOW6LM4kuKmtydngrSgKcQDlXPS1ichgaTxpKbzafZECy5YInTP4Dkv6NI7gSt8vylq12EClNzwzHIUNkSy7W1hnB1lm/z9bIlktLLBJVCp5rbmo7hc4sQZNyB2t+Af9Gg3WChAj7X4p1grWbI9YvN/cmbWklnxP06NxjWQp43s4+4vIM3sQ9bE2afs3gsK4nmu2oVlp0nBLC8U+54GdXmOQfTBH1t0a/dM0z9iwq5jw51HnopoVPJFUHmdbIWccOSu3NEWszg44RmYI19kfXP/ZJLPff/61N9mLce+DkouZa50/ScapHEO6sicXEUhPACDpnR29OMa+Jfjs8ilFqtNESKrFtUPjssAJqCXjryaWNKOll3ALACgXws+TFgAQV6phN4X25YVbjiJ9/lRNmbgj75asuYx2BGilCud8xZiXBwdIS/pTGelQpbkftme0xP1nd5vuvKQae2CSQiReHLwoiYW0ROXUvYf0xledoRrGBCrZ1luqYQxQLT3328o0kAGJl6DG1nvp7Bmk7Txa0GrX0J0fdYBg182rekc/rhYxl3PnRAHSVGiSJ43/IXfiGKWudkC++7n0hDlBbUFyucy54oBRYWNdUJb8Wl1wmdghJmH/P2BNnJ6jzffrZcx1uYbRktOZ7A79ju7j3e7U73WO5+jaAa+Q6Bmk/a2mOjcnF6aqqWQ+ojsEaROKYmuxWLQ5o7asLpn0zGBHAIrKNEfV6KOz7RmoekqqbbW+NTIzVO+FoJmXbwcIgG4bfbQ6wnj/a/ShXgItYEwsecGUFpXfGXuijNmV0HzL01s6lsvpNgG13xWvUjanRTFH1GqecsQxam2ziyg4mZ+HHAHLwDWA61QKhpD28rpkjtES12mmkqERyTZUo4FYLcPVwzJ6CKO38DV+fIkfo3+wkqbOJmMeH8IQf2/hKo5e4vWTGVM3Kh9h3JDVWxjG4VO8XpshOAG7EMR/uGLAJ641funvRy2FuTWAoVL5yfDHySz+j/uPziwtEEtnQX/7nPvz19J1U0jNRclqlAndTcqwyqg+LuDpDO1XJlK1QA9MzMr4B4a+vr5Ek4IgFU2F/VivVvPgQDVqV7x6xw/7QmJo+szUVG1cmgaxlo3pKvHkdAyMHh74Oz/1nhhlJKvezHVx3XTh4zPOTS6l6G6IKqQtbgBqVnWz9cIecWHl+rfYGo2GBLH5sV9Jt7CMbWlT6I2rp7GSDI1AIWospWL6gE6wJ1vcuArptK2ePv8FCXqcajETAAA=", "string": ""}, "status": {"code": 200, "message": "OK"}, "url": "https://api.github.com/repos/sigmavirus24/github3.py", "headers": {"X-RateLimit-Limit": "60", "X-Content-Type-Options": "nosniff", "X-GitHub-Media-Type": "github.v3; param=full; format=json", "Vary": "Accept", "Transfer-Encoding": "chunked", "ETag": "W/\"32ca9cfb3d996bc8fa8ba922c4fa3531\"", "Server": "GitHub.com", "Content-Type": "application/json; charset=utf-8", "X-XSS-Protection": "1; mode=block", "X-RateLimit-Reset": "1447372197", "X-GitHub-Request-Id": "C60DF581:146C9:1B753833:564518D7", "Status": "200 OK", "Strict-Transport-Security": "max-age=31536000; includeSubdomains; preload", "Access-Control-Allow-Credentials": "true", "Content-Encoding": "gzip", "X-Served-By": "a30e6f9aa7cf5731b87dfb3b9992202d", "X-Frame-Options": "deny", "Date": "Thu, 12 Nov 2015 22:55:19 GMT", "Cache-Control": "public, max-age=60, s-maxage=60", "Access-Control-Expose-Headers": "ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval", "Last-Modified": "Wed, 11 Nov 2015 12:38:46 GMT", "Access-Control-Allow-Origin": "*", "X-RateLimit-Remaining": "56", "Content-Security-Policy": "default-src 'none'"}}, "request": {"body": {"encoding": "utf-8", "string": ""}, "uri": "https://api.github.com/repos/sigmavirus24/github3.py", "method": "GET", "headers": {"Accept": "application/vnd.github.v3.full+json", "Accept-Encoding": "gzip, deflate", "Content-Type": "application/json", "Accept-Charset": "utf-8", "User-Agent": "github3.py/1.0.0a2", "Connection": "keep-alive"}}}, {"recorded_at": "2015-11-12T23:00:25", "response": {"body": {"encoding": "utf-8", "base64_string": "H4sIAAAAAAAAA+1YTXPiOBD9KyrvYS8YYwNhxsUws4fd2r1tzWQuG1JE2MKoxkheSSYhVP77PhmbD4c4gZmqnQMHqozc/dR66n5uae3kKnVCZ25MpkPPoxlvJ9zM82k7kgtPsUxqT/NkQZdc5TroeZu33Xa2wtuUUc20N7i6GgyclkO1ZkZPfhiktwEEcp6lksY15M2gPjfgEn39UdAFa6V0ytInTDU3i7Q20R4jr3JhaOItO+1B2wcWj52wIKflYHxiJwLZ29eGqoSZCZhecMP1HO9itmSpzOBbGuMpVnRmnHBGU81Acm7mUjnh2kllwgV89mMqJw16nXfdDoyXFJPUd6QYrHjLNVORFIYJU+x57m2cPy4/dIGWqBLDrsWxW9GUMBbsMGFOYhTGM5mm8h4o9aAPM/P5RN7Wc4vCRXImCjzXnjRzBu6wJJsXCdev5faRoAqvNapGmwmPLY4G94rVc7lWeEeQSj+EdS8Q0boozgIwn+pI8cxwKU5n7cAbaFIlVPBHeh4avDVACt04mfrCC94oAXEG1Ru3tZcpvqTRylKjWMT4EmSfCVnzB6JZZbaEvyIpLPXcsAmNF7YMi/J8ajmZYqUwbks2UowaREFRxU7Q8buu33E7/nWnE3b6Yaf3D6CyfJpCAupWwdV1JwiDfhgE1qoUxPBm3VyHbxTuDZzXHbzv9YBuS7x43qrPTu3dQtPcbBVA+ruukIK5VKza9/MUnoV6YnFvtd9INzi8yFhNLy8ydpExqN//LmNlSzApBY9mWcqj4qvgycgw42oDVVtYETQQN9R+WdNxoYuPGPH9gd9DExLji1W0b5HMBSQwuGo5RyTRd/3+dRCEXYidb8Uuz+K6bO7Z9N9bm6mS99DiyXaOw/bklM6tgijbt71Ot0n7nlo/XIr7e1Lcf1GK2+gj2sljg/juLC5yuznPHGmrLl3jpWv8ueX2wU0euT0Rvii07/p9H5pa11kf2tuss/3+T6izlWw93dpTs5rStH4eP+mWooTYHcpB5vdilhA7zKmMVxN7c4Dv4DBPR2MxTPlomI1+i2MSs4yJmIloRaQgQ0rmis0+jLeXLi99pHKF48UiS/ERHDujvX/owIceHREjCQX+189/XZd22o7FfDbDGUQYEqW2w9ft4VSN7G8svjBGcKwlsYzyBUyKLzqZSUWoMYpPc8M0uZ/zaE6ogmmF2x562WjoYVHbpf3BH1hMuNY57NQKR2Y7eYabBUaGkYzZqLpKGXrFX7v6v/M0JZ/ZvznDuZigIVCYELzMyCa+RnaUTJia52NnszBQaAXdtevAKsDRp9LCsnMk4s9sIZdVcOwhY2hkVBUc1YRivdrs79dBgE0bxzQF2DdNpw3R7YxeCHCf0kYmXrqGKnZDe37P3wujGHRTLr5h0HCTMjD3JxVxyrAVxR3e7/bIDQJ/gecmtbYbOuMiJlSQwgS5Q0GQZFr8agh7wLXGAc8ect92ZbYcDHuw593nFXCYyW/P4u/I3rFoytYqT5sTdCyq9GqPRZlKVRKRV7Pn027z4b4fjeV8r4Be5bvkF9S65Dm5N4fs3t5Mbt/OMCFjNRaEnK0S1t3+XNLE991dxfjd3SucF+HseN/Cl/zf3VU7AKTT9uBopKfuRbVesByS6hL9DXruPP0HC8PI3noXAAA=", "string": ""}, "status": {"code": 200, "message": "OK"}, "url": "https://api.github.com/repos/sigmavirus24/github3.py/releases/tags/v0.7.1", "headers": {"X-RateLimit-Limit": "60", "X-Content-Type-Options": "nosniff", "X-GitHub-Media-Type": "github.v3; param=full; format=json", "Vary": "Accept", "Transfer-Encoding": "chunked", "ETag": "W/\"08d56d9de5d817aaf3cc0c61ed579993\"", "Server": "GitHub.com", "Content-Type": "application/json; charset=utf-8", "X-XSS-Protection": "1; mode=block", "X-RateLimit-Reset": "1447372197", "X-GitHub-Request-Id": "C60DF581:146C9:1B75385D:564518D7", "Status": "200 OK", "Strict-Transport-Security": "max-age=31536000; includeSubdomains; preload", "Access-Control-Allow-Credentials": "true", "Content-Encoding": "gzip", "X-Served-By": "bd82876e9bf04990f289ba22f246ee9b", "X-Frame-Options": "deny", "Date": "Thu, 12 Nov 2015 22:55:19 GMT", "Cache-Control": "public, max-age=60, s-maxage=60", "Access-Control-Expose-Headers": "ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval", "Last-Modified": "Sat, 26 Oct 2013 02:25:22 GMT", "Access-Control-Allow-Origin": "*", "X-RateLimit-Remaining": "55", "Content-Security-Policy": "default-src 'none'"}}, "request": {"body": {"encoding": "utf-8", "string": ""}, "uri": "https://api.github.com/repos/sigmavirus24/github3.py/releases/tags/v0.7.1", "method": "GET", "headers": {"Accept": "application/vnd.github.v3.full+json", "Accept-Encoding": "gzip, deflate", "Content-Type": "application/json", "Accept-Charset": "utf-8", "User-Agent": "github3.py/1.0.0a2", "Connection": "keep-alive"}}}], "recorded_with": "betamax/0.5.1"}

‎tests/integration/test_repos_repo.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -426,13 +426,13 @@ def test_release(self):
426426

427427
assert isinstance(release, github3.repos.release.Release)
428428

429-
def test_release_by_tag_name(self):
429+
def test_release_from_tag(self):
430430
"""Test the ability to retrieve a release by tag name"""
431-
cassette_name = self.cassette_name('release')
431+
cassette_name = self.cassette_name('release_from_tag')
432432
with self.recorder.use_cassette(cassette_name):
433433
repository = self.gh.repository('sigmavirus24', 'github3.py')
434434
assert repository is not None
435-
release = repository.release_by_tag_name('v1.0.0')
435+
release = repository.release_from_tag('v0.7.1')
436436

437437
assert isinstance(release, github3.repos.release.Release)
438438

‎tests/unit/test_repos_repo.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -341,9 +341 73ED ,9 @@ def test_pages(self):
341341

342342
self.session.get.assert_called_once_with(url_for('pages'))
343343

344-
def test_release_by_tag_name(self):
344+
def test_release_from_tag(self):
345345
"""Test the request for retrieving release by tag name"""
346-
self.instance.release_by_tag_name('v1.0.0')
346+
self.instance.release_from_tag('v1.0.0')
347347

348348
self.session.get.assert_called_once_with(
349349
url_for('releases/tags/v1.0.0')

0 commit comments

Comments
 (0)
0