8000 Fix notification() method to make parameters lowercase · pythonthings/github3.py@11987f6 · GitHub
[go: up one dir, main page]
Skip to content

Commit 11987f6

Browse files
itsmemattchungitsmemattchung
committed
Fix notification() method to make parameters lowercase
1 parent 9870032 commit 11987f6

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

‎github3/repos/repo.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1517,8 +1517,8 @@ def notifications(self, all=False, participating=False, since=None,
15171517
"""
15181518
url = self._build_url('notifications', base_url=self._api)
15191519
params = {
1520-
'all': all,
1521-
'participating': participating,
1520+
'all': str(all).lower(),
1521+
'participating': str(participating).lower(),
15221522
'since': timestamp_parameter(since)
15231523
}
15241524
self._remove_none(params)

‎tests/cassettes/Repository_notifications.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"http_interactions": [{"request": {"body": {"string": "", "encoding": "utf-8"}, "headers": {"Accept-Encoding": "gzip, deflate", "Accept": "application/vnd.github.v3.full+json", "User-Agent": "github3.py/1.0.0", "Accept-Charset": "utf-8", "Content-Type": "application/json", "Authorization": "Basic <BASIC_AUTH>"}, "method": "GET", "uri": "https://api.github.com/repos/sigmavirus24/github3.py"}, "response": {"body": {"string": "", "base64_string": "H4sIAAAAAAAAA62YXY+rNhCG/0rEbbNxCNlsglSd9qrt3bk4velNZMAEawEj2yTKov3vfY2BQI6aj3WlVZSwnsevxzNmxo3HEy8M3vzlm+/PvZIWzAu9A9dZHQWL6uzNvbTO8333D8UPBT1yWavVmkxGiVPJpBc2Xi4OvARjPBQUM81qvdwGy7lHj1RTua9ljnGZ1pUKCbEP1cJSa8VkLErNSr2IRUFqYo2/HX9dgXaQHcNgvdhfb4PXTbLdpbvVK9vsVv7bNmLMT3YBjdM3GFzNVfFuHgvHZIpcCc50kV9JtNJak6vBqchzcQLlelH3JiKDpfF0S+Hl4YsUWDZE6IzBt1jSp3EUV/p5Ua1Vgw1Wes8Tw1HYMMmSp4V1dpBl4uOzIZJVogXWkYolrzQX5fMCJ9agCXmgJf+gX6PBWgFipD0vpbWCNTsiVp83t2YNqSQ/0vhsXCNZzPgRzv4i8soeRH2uTFr/jaAwruea7WlSmDRNaa7Y59xrp9cY1D6YIysfjf7pMZCwYVcx4fezzkQ5y3kkqTzPUiFnHDktUxojVmcnHDMzhOvsD67/rKPZ79//OgYQiHHvg5Kbmds6f5KMUzmGdGdPbiKQngBA0js7O3GMfUPw2eVTjFSnkZBUi3uHxm2BE1BDxj9NLGlGCyfhLQCgTAg3T7YAgLhSNXsotG8vvOUo0udPWReRPfIeyZrbaEuAVqpwzpeMOXlwgDSkP5WRDmWcuWF7RkPst3a36cFJqrEHJspF5MTBi5K0kIaojNr3kN67qjNUw5hAJUudpRrGANXScb9bmQYyIPES1Nh6J509gzSdR3NaHmp6cKMOEOy6eVUf6MfdIuZ27lwoQJoKTvKodj/kLhyj1NYOyHc3l14wF2hbkNwuc+44YFTYtC4oCn6vLrhN7BCTsP8fsCZOr9Hm9/0y5r5cw2jI5Uy2h35Hd/Fud+r3OklzmaNrF5xComeQ5peK6sycXJiqopK5iO4QpIkoiq3FYtFkjLZldcGkYwZbAlBUxhmqRhedTc9A1VNQ3VbrqZGZoHrPBU2cfDtAALTb6KLVEsYxVqFPdRLYAsbEgudMaVG6nbEXyphdCs1THj/SsdxOtwmo+aZ4GbM5zfM5olbzmCOOUWubXUTBydw8ZAlYBq4JbKeSM4S0k9cls4yG2E4zlgyNSLKnGg3EaumvXpbBix/88Hfh6zZ8Df7BSuoqmYxZvyy3+Pvhv4WrVfi6NGOqWmUjjB2yMxgM8TdmCE7ALgTxDVcQ+MS1x0/9/ailMLcGMFQquxj+djEL/+N+pDOLc8TSVdA/Pufx+rV03xRSM1GwCmVCd9MyrDKozgt4OkH7lYhYLdADE7My/oGhu/UmmBQEsahL7Ie/28y9E9WoXfHqHT/sC4mh6TNTU7W3aeqFWtamq8STyzEwenji73zo+GzT1tE3O5ySXErR3ReVSFL0+xUrO/YgY2sbR+WFxmY0Arrxv152t4qEpbTO9d4Wz5CdoOrPRWUih8kCus3FhLnQ6jpluwITVf1qzHlhv6OBLpk+oVfs1RgJ4zKl99X2819he1kIchMAAA==", "encoding": "utf-8"}, "headers": {"vary": "Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding", "x-served-by": "971af40390ac4398fcdd45c8dab0fbe7", "x-xss-protection": "1; mode=block", "x-content-type-options": "nosniff", "etag": "\"d788d2d447e1f828e4e0672c124149ef\"", "access-control-allow-credentials": "true", "s C0F3 tatus": "200 OK", "x-ratelimit-remaining": "4987", "x-github-media-type": "github.v3; param=full; format=json", "access-control-expose-headers": "ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval", "transfer-encoding": "chunked", "x-github-request-id": "48A0C4D3:7B5D:26B4A60:53E6DCD0", "cache-control": "private, max-age=60, s-maxage=60", "last-modified": "Fri, 08 Aug 2014 17:22:50 GMT", "date": "Sun, 10 Aug 2014 02:45:36 GMT", "access-control-allow-origin": "*", "content-security-policy": "default-src 'none'", "content-encoding": "gzip", "strict-transport-security": "max-age=31536000; includeSubdomains", "server": "GitHub.com", "x-ratelimit-limit": "5000", "x-frame-options": "deny", "content-type": "application/json; charset=utf-8", "x-ratelimit-reset": "1407641433"}, "status": {"message": "OK", "code": 200}, "url": "https://api.github.com/repos/sigmavirus24/github3.py"}, "recorded_at": "2014-08-10T02:45:37"}, {"request": {"body": {"string": "", "encoding": "utf-8"}, "headers": {"Accept-Encoding": "gzip, deflate", "Accept": "application/vnd.github.v3.full+json", "User-Agent": "github3.py/1.0.0", "Accept-Charset": "utf-8", "Content-Type": "application/json", "Authorization": "Basic <BASIC_AUTH>"}, "method": "GET", "uri": "https://api.github.com/repos/sigmavirus24/github3.py/notifications?participating=False&per_page=100&all=False"}, "response": {"body": {"string": "", "base64_string": "H4sIAAAAAAAAA62YXY/iNhSG/wrKbVkMAWaGkapV1Yt2b6rRqr3pqkJO4iTuJHFqOyA2mv/e9zgBAlUzw3huEBCfx+fbx/nWBjIJHoPlarXehJv7YBo0lRYc/1ndiGmA70ZVWGGayMRaRiKhNXXCrUi23OJJOF+sPs3vPi0Wv4fh43L1uF79iTUFN3ZLKLeqaopiSpC/RYyfbWClLQSkfxP7CbcW5MYKM0mVnjxh7VfxTyOM/Sp2Uux/VmUpKjsRO3wa2l8XEM2trc0jY7yWs0zavIlmsSqZFrUyzMis5DupGxOuWPd0OasPTBoDMAvXZGsBK6AlpIi//SisPdRk2hfaKnghJ0IjaZU+kOXk8OX9Yn6/WEyDipe09KwgtEph/7Z/8D9mYJXaV0ITr1CZdBEaWIzntE24mj8s59OA77jl+to+96fpXdcYoWNVWfjBebFhnfDn3Y8haJnuGS5d4sXqYbm+Sx426SZci7tNuLh/iIRYJJslj1OXRmMhos0uQwSJ3JbFlYqDqF5Zl6qiUHtQro26zIX/bsROkuRpR5FV9k4KJFumbC7gW5j0Qo6Sxt6ulJNqkafIRpkQxyA2GiV2ox9ZLwe1KD9eWlcODtgVcG2lqm5X8EIaNKUzXsnv/H00SFMZu7q42UInBemuG9ws3om1rNZyx+MDuUaLWMgdnP1O5JU8iH0H+ANJQa6XVmx5UlKZprwwAj3BbW9R++6PW7J/0M3ATgS1ZRdVFObTweaqmhQy0lwfXDeVqGmd8hi5OtmjS06QrpNfpP21iSY/PX3ZLQHBuueTJqMZN9pce9IrIR1FoDz1M0X3WRy8OCTfMnz29RSj1HmkNEcb9gJfgFo2/Em5ZAUvvfgOAFCu1LMXyAEAcifem1J7PDL9yXmsn6opo67lvaVqxtGng50b9PlKCC/DT5CWHbsyyqGKcz/skdGy7puLNs+8VCV5YKJCRV4cHJTMQVpmct6dQ3brqx1RiXEB1SL1VpUYJ6jVnvF2ahLkhMQhaBF6Lz2PDNb2Hi14lTU886OeIIg6HdUZ//7qEDNeO2cKkDTBuVHau8mdOaTpcfj3a50DzBnqjq7xU/wVBwwGG+eCspSvjWDjxB5xkfYfgKU8vUb3Vw+vTD0yWnbuyV3T/7iLzXEP1p736K8Lnrq7K4dh7Q81tzl1LmxVcy18UqJHsDbiGLZms1mb4yJK8FJozwruCEBxHeeYGn30bI8MTD0lt25aT0nNBNN7oXji5dsTBMDu8PbRtSMMc6zGPdVLQQcYEktZ4D6uKr8ee6YM2ZWyMpXxW24s493hAtR+NrKKxZTj9Qay1spYIo8xa1MUMXAKPw91BJiB1wTdTaXACxk/92jRMVpGN01cRUYH/gtrmc3pjY5hg/dFw5vheH6No9gQFLz89S/mnOF4mxIAAA==", "encoding": "utf-8"}, "headers": {"vary": "Accept, Authorization, Cookie, X-GitHub-OTP, Accept-Encoding", "x-served-by": "6d7de9e645814cac34ea2a8d72ba3141", "x-xss-protection": "1; mode=block", "x-content-type-options": "nosniff", "etag": "nil", "access-control-allow-credentials": "true", "x-poll-interval": "60", "status": "200 OK", "x-ratelimit-remaining": "4986", "x-github-media-type": "github.v3; param=full; format=json", "access-control-expose-headers": "ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval", "transfer-encoding": "chunked", "x-github-request-id": "48A0C4D3:7B5D:26B4A89:53E6DCD0", "cache-control": "private, max-age=60, s-maxage=60", "last-modified": "Wed, 11 Jun 2014 22:34:54 GMT", "date": "Sun, 10 Aug 2014 02:45:36 GMT", "access-control-allow-origin": "*", "content-security-policy": "default-src 'none'", "content-encoding": "gzip", "strict-transport-security": "max-age=31536000; includeSubdomains", "server": "GitHub.com", "x-ratelimit-limit": "5000", "x-frame-options": "deny", "content-type": "application/json; charset=utf-8", "x-ratelimit-reset": "1407641433"}, "status": {"message": "OK", "code": 200}, "url": "https://api.github.com/repos/sigmavirus24/github3.py/notifications?participating=False&per_page=100&all=False"}, "recorded_at": "2014-08-10T02:45:37"}], "recorded_with": "betamax/0.4.0"}
1+
{"http_interactions": [{"request": {"body": {"string": "", "encoding": "utf-8"}, "headers": {"Accept-Encoding": "gzip, deflate", "Accept": "application/vnd.github.v3.full+json", "User-Agent": "github3.py/1.0.0a2", "Accept-Charset": "utf-8", "Connection": "keep-alive", "Content-Type": "application/json", "Authorization": "Basic <BASIC_AUTH>"}, "method": "GET", "uri": "https://api.github.com/repos/sigmavirus24/github3.py"}, "response": {"body": {"string": "", "base64_string": "H4sIAAAAAAAAA62YwY7iOBCGXwXlujQm0KinI41m9rS7tznMXvaCTGKI1Ukc2Q6Ijvrd9y87CQmjhe72XhAE1+ff5Sqnym0ksyhZP8XLpzieRxUvRZREB2nzZrde1OdoHu2both2fxh5KPlR6sasHtlklDpVQkdJGxXqICswxkNBoWlWj8sv6+U84kduud42usC43NraJIz5h2bhqY0ROlWVFZVdpKpkDfPG345f16AddMcgbIQHV6xadhxvDJhhV4JyWxZXEvzUzuRq8F4VhTqBci363kRssCRPOoqsDp+kwLJlyuYCvsOS3sgR0tiPi3JWLTbQ2K3MiGOwIVpkHxbW2UEW7f9by7SolQM2O5NqWVupqo8LnFiDpvSBV/KVf44GawMISfu4FGcFa3FELH7c3Ju1rNbyyNMzuUaLVMgjnP1J5JU9iPZcU9r+jaAg10srtjwrKQ33vDDibR656S0GuQdzZN17o3+a5pkYdhUT/jjbXFWzQu401+fZXumZRM7qPU8Rq7MTjpEZwnX2h7R/NrvZ7z/+OlL2YtzLoORm5jrnT5JxKodId/bkJgLpCQAkvYhzEIfsW4bPLp9SpDrfKc2tundo3BY4AbVs/JNiyQpeBgl3AIBypcI86QAASWMa8a7Qvr1wxzGsz5+qKXf+yHtP1txGewK0coNzvhIiyIMDpGX9qYx0qNI8DNszWua/ud3mhyCpZA/MrlC7IA5elMxBWmZy7t9DdhuqjqjEmEC12AdLJcYAtTpwv51MggxIvAQttj5IZ89gbefRgleHhh/CqAMEu06v6gN/vVvE3M6dCwVIqtC03DXhh9yFQ0p97YB8D3PpBXOBuoLkdplzxwGjwsa5oCzlvbrgNrFDTML+f8BSnF6j6ff9Mua+XGK07HIm+0O/o4d4tzv1e53jObp2ICgkegZrf6u5zenkwlQ11yJEdIdg7Y6j2FosFm0uuCurS6EDM9gTgOI6zVE1huhsewaqnpJbV63vSWaG6r1QPAvy7QAB0G9jiFZPGO9/jT40SKADjImlLISxqgo7Yy+UMbtSVu5l+p6O5Xa6TUDtNyOrVMx5UcwRtVamEnGMWpt2EQWnCPOQJ2AZuAbwnUohENJBXtfCM1rmO81UCzQi2ZZbNBCrZbx6WK4f4vXP+DnZfEk263+wkqbOJmM2D3H8EC9/xisMSDYbGlM3Jh9hhiFxEsfJ+pGG4ATsQhDfcMWAT1xr/NLfj1oKujWAoTH5xfD7xSz5j/uPziwtEEtXQf/+OY/Xr6X7ppCaq1LUKBO6m5Rhlev6vICnM7RfmUrNAj0wo5XJVwx9fnp+nhQEqWoq7MfjCrczJ25Ru+LVO37YFxJD00dTc7P1aRolVjfUVeLJ5RgYPTzJF3npPTGKJJvezHdx3XTxZoNzU2qtuhuiCmmLG4BaVN1svbDNo28lwXFGoyFRQn/2K+kWlok9bwq79fU0VpKhEShUTcEkdIml0F0F3WGNm2cfaYN4OkS8bnTVlbAnNJC9IKdiXLx0S1pt3v4FGY5QqWgTAAA=", "encoding": "utf-8"}, "headers": {"vary": "Accept, Authorization, Cookie, X-GitHub-OTP", "x-github-media-type": "github.v3; param=full; format=json", "x-xss-protection": "1; mode=block", "x-content-type-options": "nosniff", "etag": "W/\"6994bcb8d393e21ca943089029e5021e\"", "cache-control": "private, max-age=60, s-maxage=60", "status": "200 OK", "x-ratelimit-remaining": "4989", "x-served-by": "c6c65e5196703428e7641f7d1e9bc353", "access-control-expose-headers": "ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval", "transfer-encoding": "chunked", "x-github-request-id": "97E1C718:7FBE:1065499B:564227F6", "access-control-allow-credentials": "true", "last-modified": "Tue, 10 Nov 2015 12:53:55 GMT", "date": "Tue, 10 Nov 2015 17:23:02 GMT", "access-control-allow-origin": "*", "content-security-policy": "default-src 'none'", "content-encoding": "gzip", "strict-transport-security": "max-age=31536000; includeSubdomains; preload", "server": "GitHub.com", "x-ratelimit-limit": "5000", "x-frame-options": "deny", "content-type": "application/json; charset=utf-8", "x-ratelimit-reset": "1447179651"}, "status": {"message": "OK", "code": 200}, "url": "https://api.github.com/repos/sigmavirus24/github3.py"}, "recorded_at": "2015-11-10T17:23:02"}, {"request": {"body": {"string": "", "encoding": "utf-8"}, "headers": {"Accept-Encoding": "gzip, deflate", "Accept": "application/vnd.github.v3.full+json", "User-Agent": "github3.py/1.0.0a2", "Accept-Charset": "utf-8", "Connection": "keep-alive", "Content-Type": "application/json", "Authorization": "Basic <BASIC_AUTH>"}, "method": "GET", "uri": "https://api.github.com/repos/sigmavirus24/github3.py/notifications?participating=false&per_page=100&all=false"}, "response": {"body": {"string": "", "base64_string": "H4sIAAAAAAAAA62Y36/aNhTH/5UoT6vGxYQLF4o0VXvZ1rdq2l42TcgJJvFI4sx2uKMR/3u/xwkQ6BpKvReEEp+Pz28f588mlJtwFUaT5XL+Ek2X4SisSy04Hlpdi1GI/0aVWFKI0kr8w4Jqw63YrLnF4+kkmj9F0VM0+S1arKbT1Wz6B9bk3Ng1cT5fNV9Fb1ezF1pl6vhvkQDThFbaXID33phaBLOXZfAU/CT/DUpl5VYmnPb+7k1QCJupTWBVUPCdCCquOR4JbYJcvQqdcCNIQ50DlVlbmRVjvJLjVNqsjseJKpgWlTLMyLTge6lrM52x9u3zuDqwqs5zw2aLiTPCCpgBITJ+7UGVZJVhHcmwaD6fvV1Eszl2sYeKDP+AjX8V/2CZDY/kd2gprdIH8g4F6XkRTRZRNApLmAyBi9KAbCG97l58wTSsUq+l0MTLVSopqP2leE/bTGeT5fNkFPI9t1zfGu0ems6dtYHHVWnhHOfZmrXC7/Y/PIOW6o7hUuxeWAh2HRZIZLbIb1ToRfJG+63KXRKYW6Wv4//5RuwsSZ50FFmm30iBZMOUzQR8B5OO5Ahp7ONKOakGuYkUlBviGPheo/AGE/E/zOvkoBbF/9i4EnDAOjaJlhUV1+MKXkmDpnTKS/nRlerjNEgbQFzeP2yhk4K02CMXHxdvxRpWabnnyYFco0Ui5B7O/kbkjTyIXZ3/jqQg10sr1nxTUBlueW4Eat5tb1Hb7sEj2d/rYGBvxDmq1FgOaJllkMtYc30ItkoHEjWrtzxBrgav6IwB0jX4Wdpf6jj48cP7PVUv1u3Omgxm3GBD7Uh3YjKIQHnqHUV3Jw5eHJJvGH67ekpQ6jxWmqPNeoGvQA3a/IVLuWQFL7z4DgBQptTOC+QAALnz6KtSezgy3bl2qp+yLuK25X1N1QyjWwJ05QZ9vhTCy/AzpGGnroxyKJPMD3tiNKz956LNUy9VSR6YOFexFwcHJXOQhpmMt+eQXftqR1RiXEG12HqrSowz1GrPeDs1CXJG4hC0CL2XnicGazqP5rxMa576Uc8QRJ2O6pR/vDvEDNfOhQIkTWhaxrV/k7twSNN2dkC9+7n0grlA3UAyPATccUBvsHEuKAp5by4YJnaIq7T/H7CUp7fo0y3BxwEnRsMuPblt+t0bH/jNbaa/R3cd8EqJE4M131fcZtS5oDSuesJH6Q7Bmhh3xON4PG4yXE8JXgjtWcEtASiukwxTo4+ezYmBqafg1k3rW1Jzg+k9V3zj5dszBMA2jD66toR+/N312QfpAH1iIXNciVXp12MvlD67/3HBS+srUPPOyDIRI57nI2StlYlEHmPWpihi4BR+HmoJMAOfAdqbSo5vNH7u0aJlNIxumriKDA78V9Yym9F3HnzT6H1D6l8Nh7PhDov1SeHxr0/D6UXvsRIAAA==", "encoding": "utf-8"}, "headers": {"vary": "Accept, Authorization, Cookie, X-GitHub-OTP", "x-github-media-type": "github.v3; param=full; format=json", "x-xss-protection": "1; mode=block", "x-content-type-options": "nosniff", "cache-control": "private, max-age=60, s-maxage=60", "x-poll-interval": "60", "status": "200 OK", "x-ratelimit-remaining": "4988", "x-served-by": "e724c57ebb9961c772a91e2dd7421c8d", "access-control-expose-headers": "ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval", "transfer-encoding": "chunked", "x-github-request-id": "97E1C718:7FBE:106549DD:564227F6", "access-control-allow-credentials": "true", "last-modified": "Tue, 10 Nov 2015 17:22:42 GMT", "date": "Tue, 10 Nov 2015 17:23:03 GMT", "access-control-allow-origin": "*", "content-security-policy": "default-src 'none'", "content-encoding": "gzip", "strict-transport-security": "max-age=31536000; includeSubdomains; preload", "server": "GitHub.com", "x-ratelimit-limit": "5000", "x-frame-options": "deny", "content-type": "application/json; charset=utf-8", "x-ratelimit-reset": "1447179651"}, "status": {"message": "OK", "code": 200}, "url": "https://api.github.com/repos/sigmavirus24/github3.py/notifications?participating=false&per_page=100&all=false"}, "recorded_at": "2015-11-10T17:23:02"}], "recorded_with": "betamax/0.5.0"}

‎tests/unit/test_repos_repo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,7 @@ def test_notifications(self):
611611

612612
self.session.get.assert_called_once_with(
613613
url_for('notifications'),
614-
params={'per_page': 100, 'participating': False, 'all': False},
614+
params={'per_page': 100, 'participating': 'false', 'all': 'false'},
615615
headers={}
616616
)
617617

0 commit comments

Comments
 (0)
0