8000 why msbuild added to %path% in bld.bat for conda build? · Issue #438 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

why msbuild added to %path% in bld.bat for conda build? #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
den-run-ai opened this issue Mar 23, 2017 · 6 comments
Closed

why msbuild added to %path% in bld.bat for conda build? #438

den-run-ai opened this issue Mar 23, 2017 · 6 comments

Comments

@den-run-ai
Copy link
Contributor
den-run-ai commented Mar 23, 2017 •
edited
Loading

#435 (comment)
@filmor
Copy link
Member
filmor commented Mar 23, 2017

Nice description 😜

I had problems in the past with using the script element in the conda recipe, which can in theory look like

script: "python setup.py install",

So: "yes".

I'm not sure, why $PATH is overridden in there, though.

@filmor filmor closed this as completed Mar 23, 2017
@den-run-ai den-run-ai changed the title bld.bat required for conda build? why msbuild added to %path% in bld.bat for conda build? Mar 23, 2017
@den-run-ai
Copy link
Contributor Author

@filmor I update the title: why msbuild added to %path% in bld.bat for conda build?

@den-run-ai den-run-ai reopened this Mar 23, 2017
@vmuriart
Copy link
Contributor

I think msbuild was added there since alot of packages have issues detecting the presence of msbuild. The recipe was copied from another example probably that used it. In our case its most likely not needed, though I havent tested it yet.

@vmuriart
Copy link
Contributor

bah. build fails without path. Atleast in AppVeyor it looks like the wrong msbuild is being selected.

@den-run-ai
Copy link
Contributor Author

@vmuriart so we can close this issue?

@vmuriart
Copy link
Contributor

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@filmor @den-run-ai @vmuriart
0