8000 mention-bot: Automatically mention potential reviewers on pull requests. · Issue #416 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

mention-bot: Automatically mention potential reviewers on pull requests. #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
den-run-ai opened this issue Mar 3, 2017 · 7 comments
Closed

mention-bot: Automatically mention potential reviewers on pull requests. #416

den-run-ai opened this issue Mar 3, 2017 · 7 comments

Comments

@den-run-ai
Copy link
Contributor

https://github.com/facebook/mention-bot
@den-run-ai
Copy link
Contributor Author

I added the webhook, and it is customizable by adding .mention-bot file:

{
  "maxReviewers": 5, // Maximum  number of people to ping in the PR message, default is 3
  "numFilesToCheck": 10, // Number of files to check against, default is 5
  "message": "@pullRequester, thanks! @reviewers, please review this.",
             // custom message using @pullRequester and @reviewers
  "alwaysNotifyForPaths": [
    {
      "name": "ghuser", // The user's Github username
      "files": ["src/js/**/*.js"], // The array of file globs associated with the user
      "skipTeamPrs": false // mention-bot will exclude the creator's own team from mentions
    }
  ], // Users will always be mentioned based on file glob
  "fallbackNotifyForPaths": [
    {
      "name": "ghuser", // The user's Github username
      "files": ["src/js/**/*.js"], // The array of file globs associated with the user
      "skipTeamPrs": false // mention-bot will exclude the creator's own team from mentions
    }
  ], // Users will be mentioned based on file glob if no other user was found
  "findPotentialReviewers": true, // mention-bot will try to find potential reviewers based on files history, if disabled, `alwaysNotifyForPaths` is used instead
  "fileBlacklist": ["*.md"], // mention-bot will ignore any files that match these file globs
  "userBlacklist": [], // Users in this list will never be mentioned by mention-bot
  "userBlacklistForPR": [], // PR made by users in this list will be ignored
  "requiredOrgs": [], // mention-bot will only mention user who are a member of one of these organizations
  "actions": ["opened"], // List of PR actions that mention-bot will listen to, default is "opened"
  "skipAlreadyAssignedPR": false, // mention-bot will ignore already assigned PR's
  "skipAlreadyMentionedPR": false, // mention-bot will ignore if there is already existing an exact mention
  "assignToReviewer": false, // mention-bot assigns the most appropriate reviewer for PR
  "createReviewRequest": false, // mention-bot creates review request for the most appropriate reviewer for PR
  "createComment": true, // mention-bot creates a comment mentioning the reviewers for the PR
  "skipTitle": "", // mention-bot will ignore PR that includes text in the title,
  "withLabel": "", // mention-bot will only consider PR's with this label. Must set actions to ["labeled"].
  "delayed": false, // mention-bot will wait to comment until specified time in `delayedUntil` value
  "delayedUntil": "3d", // Used if delayed is equal true, permitted values are: minutes, hours, or days, e.g.: '3 days', '40 minutes', '1 hour', '3d', '1h', '10m'
  "skipCollaboratorPR": false // mention-bot will ignore if PR is made by collaborator
}

@vmuriart
Copy link
Contributor
vmuriart commented Mar 3, 2017

since its implemented, ok to close issue ?

@den-run-ai
Copy link
Contributor Author
den-run-ai commented Mar 3, 2017 via email

@den-run-ai
Copy link
Contributor Author

@vmuriart so mentionbot was not working on your recent pull request, which I fixed in the settings today:

#427

@den-run-ai
Copy link
Contributor Author

ok, mentionbot is working now:

#435 (comment)

@den-run-ai
Copy link
Contributor Author

@denfromufa is there a way to exclude to AUTHORS.md from mention-bot?

yes, it is this setting file that I'm adding:

#416 (comment)

@den-run-ai
Copy link
Contributor Author
den-run-ai commented Mar 23, 2017 •
edited
Loading

@vmuriart this should pickup exception for .md files now:

https://github.com/pythonnet/pythonnet/blob/master/.mention-bot#L21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@den-run-ai @vmuriart
0