pythonnet
diff --git a/‎src/embed_tests/Codecs.cs
Lines changed: 1 addition & 23 deletions b/‎src/embed_tests/Codecs.cs
Lines changed: 1 addition & 23 deletions
diff --git a/‎src/runtime/Codecs/IterableDecoder.cs
Lines changed: 1 addition & 1 deletion b/‎src/runtime/Codecs/IterableDecoder.cs
Lines changed: 1 addition & 1 deletion
diff --git a/‎src/runtime/Codecs/ListDecoder.cs
Lines changed: 3 additions & 2 deletions b/‎src/runtime/Codecs/ListDecoder.cs
Lines changed: 3 additions & 2 deletions
diff --git a/‎src/runtime/CollectionWrappers/IterableWrapper.cs
Lines changed: 1 addition & 1 deletion b/‎src/runtime/CollectionWrappers/IterableWrapper.cs
Lines changed: 1 addition & 1 deletion
diff --git a/‎src/runtime/CollectionWrappers/SequenceWrapper.cs
Lines changed: 1 addition & 1 deletion b/‎src/runtime/CollectionWrappers/SequenceWrapper.cs
Lines changed: 1 addition & 1 deletion
@@ -98,34 +98,12 @@ static void TupleRoundtripGeneric<T, TTuple>()
             }
         }
 
-        static string GetIntIterableCommands(string instanceName)
-        {
-            var builder = new System.Text.StringBuilder();
-            builder.AppendLine(@"
-class foo():
-    def __init__(self):
-        self.counter = 0
-    def __iter__(self):
-        return self
-    def __next__(self):
-        if self.counter == 3:
-            raise StopIteration
-        self.counter = self.counter + 1
-        return self.counter");
-
-            builder.AppendLine(instanceName + " = foo()");
-            return builder.ToString();
-        }
-
         static PyObject GetPythonIterable()
         {
-            var locals = new PyDict();
             using (Py.GIL())
             {
-                PythonEngine.Exec(GetIntIterableCommands("foo_instance"), null, locals.Handle);
+                return PythonEngine.Eval("map(lambda x: x, [1,2,3])");
             }
-
-            return locals.GetItem("foo_instance");
         }
 
         [Test]
 
@@ -19,7 +19,7 @@ internal static bool IsIterable(Type targetType)
 
         internal static bool IsIterable(PyObject objectType)
         {
-            return objectType.HasAttr("__iter__");
+            return Runtime.PyIter_Check(objectType.Handle);
         }
 
         public bool CanDecode(PyObject objectType, Type targetType)
 
@@ -15,10 +15,11 @@ private static bool IsList(Type targetType)
 
         private static bool IsList(PyObject objectType)
         {
+            //TODO accept any python object that implements the sequence and list protocols
             //must implement sequence protocol to fully implement list protocol
-            if (!SequenceDecoder.IsSequence(objectType)) return false;
+            //if (!SequenceDecoder.IsSequence(objectType)) return false;
 
-            //returns wheter the type is a list.
+            //returns wheter the type is a list.
             return objectType.Handle == Runtime.PyListType;
         }
 
 
@@ -12,7 +12,7 @@ public IterableWrapper(PyObject pyObj)
         {
             if (pyObj == null)
                 throw new ArgumentNullException();
-            pyObject = pyObj;
+            pyObject = new PyObject(pyObj.Reference);
         }
 
         IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
 
@@ -14,7 +14,7 @@ public int Count
         {
             get
             {
-                var size = Runtime.PySequence_Size(pyObject.Handle);
+                var size = Runtime.PySequence_Size(pyObject.Reference);
                 if (size == -1)
                 {
                     Runtime.CheckExceptionOccurred();
Original file line number	Diff line number	Diff line change
`@@ -98,34 +98,12 @@ static void TupleRoundtripGeneric<T, TTuple>()`
`98`	`98`	`}`
`99`	`99`	`}`
`100`	`100`
`101`		`- static string GetIntIterableCommands(string instanceName)`
`102`		`- {`
`103`		`- var builder = new System.Text.StringBuilder();`
`104`		`- builder.AppendLine(@"`
`105`		`-class foo():`
`106`		`- def __init__(self):`
`107`		`- self.counter = 0`
`108`		`- def __iter__(self):`
`109`		`- return self`
`110`		`- def __next__(self):`
`111`		`- if self.counter == 3:`
`112`		`- raise StopIteration`
`113`		`- self.counter = self.counter + 1`
`114`		`- return self.counter");`
`115`		`-`
`116`		`- builder.AppendLine(instanceName + " = foo()");`
`117`		`- return builder.ToString();`
`118`		`- }`
`119`		`-`
`120`	`101`	`static PyObject GetPythonIterable()`
`121`	`102`	`{`
`122`		`- var locals = new PyDict();`
`123`	`103`	`using (Py.GIL())`
`124`	`104`	`{`
`125`		`- PythonEngine.Exec(GetIntIterableCommands("foo_instance"), null, locals.Handle);`
	`105`	`+ return PythonEngine.Eval("map(lambda x: x, [1,2,3])");`
`126`	`106`	`}`
`127`		`-`
`128`		`- return locals.GetItem("foo_instance");`
`129`	`107`	`}`
`130`	`108`
`131`	`109`	`[Test]`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ internal static bool IsIterable(Type targetType)`
`19`	`19`
`20`	`20`	`internal static bool IsIterable(PyObject objectType)`
`21`	`21`	`{`
`22`		`- return objectType.HasAttr("__iter__");`
	`22`	`+ return Runtime.PyIter_Check(objectType.Handle);`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`public bool CanDecode(PyObject objectType, Type targetType)`
Original file line number	Diff line number	Diff line change
`@@ -15,10 +15,11 @@ private static bool IsList(Type targetType)`
`15`	`15`
`16`	`16`	`private static bool IsList(PyObject objectType)`
`17`	`17`	`{`
	`18`	`+ //TODO accept any python object that implements the sequence and list protocols`
`18`	`19`	`//must implement sequence protocol to fully implement list protocol`
`19`		`- if (!SequenceDecoder.IsSequence(objectType)) return false;`
	`20`	`+ //if (!SequenceDecoder.IsSequence(objectType)) return false;`
`20`	`21`
`21`		`- //returns wheter the type is a list.`
	`22`	`+ //returns wheter the type is a list.`
`22`	`23`	`return objectType.Handle == Runtime.PyListType;`
`23`	`24`	`}`
`24`	`25`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public IterableWrapper(PyObject pyObj)`
`12`	`12`	`{`
`13`	`13`	`if (pyObj == null)`
`14`	`14`	`throw new ArgumentNullException();`
`15`		`- pyObject = pyObj;`
	`15`	`+ pyObject = new PyObject(pyObj.Reference);`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ public int Count`
`14`	`14`	`{`
`15`	`15`	`get`
`16`	`16`	`{`
`17`		`- var size = Runtime.PySequence_Size(pyObject.Handle);`
	`17`	`+ var size = Runtime.PySequence_Size(pyObject.Reference);`
`18`	`18`	`if (size == -1)`
`19`	`19`	`{`
`20`	`20`	`Runtime.CheckExceptionOccurred();`