fixed tuple codec not clearing Python exception after unsuccessful element decoding attempt (#1083)

lostmsu · web-flow · commit a320d49b0b10 · 2020-03-10T09:35:15.000+01:00
diff --git a/src/runtime/Codecs/TupleCodecs.cs b/src/runtime/Codecs/TupleCodecs.cs
@@ -81,6 +81,7 @@ public bool TryDecode<T>(PyObject pyObj, out T value)
                 IntPtr pyItem = Runtime.PyTuple_GetItem(pyObj.Handle, itemIndex);
                 if (!Converter.ToManaged(pyItem, itemTypes[itemIndex], out elements[itemIndex], setError: false))
                 {
+                    Exceptions.Clear();
                     return false;
                 }
             }
@@ -105,6 +106,7 @@ static bool Decode(PyObject tuple, out object value)
                 var pyItem = Runtime.PyTuple_GetItem(tuple.Handle, itemIndex);
                 if (!Converter.ToManaged(pyItem, typeof(object), out elements[itemIndex], setError: false))
                 {
+                    Exceptions.Clear();
                     return false;
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ public bool TryDecode<T>(PyObject pyObj, out T value)`
`81`	`81`	`IntPtr pyItem = Runtime.PyTuple_GetItem(pyObj.Handle, itemIndex);`
`82`	`82`	`if (!Converter.ToManaged(pyItem, itemTypes[itemIndex], out elements[itemIndex], setError: false))`
`83`	`83`	`{`
	`84`	`+ Exceptions.Clear();`
`84`	`85`	`return false;`
`85`	`86`	`}`
`86`	`87`	`}`
`@@ -105,6 +106,7 @@ static bool Decode(PyObject tuple, out object value)`
`105`	`106`	`var pyItem = Runtime.PyTuple_GetItem(tuple.Handle, itemIndex);`
`106`	`107`	`if (!Converter.ToManaged(pyItem, typeof(object), out elements[itemIndex], setError: false))`
`107`	`108`	`{`
	`109`	`+ Exceptions.Clear();`
`108`	`110`	`return false;`
`109`	`111`	`}`
`110`	`112`