Revert previous commit "Add cleaunp to class info"

BadSingleton · BadSingleton · commit 7e5ab5216754 · 2020-08-27T14:51:38.000-04:00
And change the scope of the ClassInfo class and add some documentation.
diff --git a/src/runtime/classmanager.cs b/src/runtime/classmanager.cs
@@ -215,6 +215,8 @@ private static void InitClassBase(Type type, ClassBase impl)
                 var item = (ManagedType)iter.Value;
                 var name = (string)iter.Key;
                 Runtime.PyDict_SetItemString(dict, name, item.pyHandle);
+                // Decref the item now that it's been used.
+                item.DecrRefCount();
             }
 
             // If class has constructors, generate an __doc__ attribute.
@@ -461,41 +463,22 @@ private static ClassInfo GetClassInfo(Type type)
 
             return ci;
         }
-    }
-
-
-    internal class ClassInfo : IDisposable
-    {
-        public Indexer indexer;
-        public Hashtable members;
-
-        internal ClassInfo()
-        {
-            members = new Hashtable();
-            indexer = null;
-        }
-
-        ~ClassInfo()
+        
+        /// <summary>
+        /// This class owns references to PyObjects in the `members` member.
+        /// The caller has responsibility to DECREF them.
+        /// </summary>
+        private class ClassInfo
         {
-            Dispose();
-        }
-
-        private bool disposed = false;
+            public Indexer indexer;
+            public Hashtable members;
 
-        public void Dispose()
-        {
-            if (!disposed)
+            internal ClassInfo()
             {
-                disposed = true;
-                foreach(DictionaryEntry member in members)
-                {
-                    var item = (ManagedType)member.Value;
-                    if (item != null)
-                    {
-                        item.DecrRefCount();
-                    }
-                }
+                members = new Hashtable();
+                indexer = null;
             }
         }
     }
+
 }
