|
| 1 | +using System; |
| 2 | +using System.CodeDom.Compiler; |
| 3 | +using System.Reflection; |
| 4 | +using NUnit.Framework; |
| 5 | +using Python.Runtime; |
| 6 | + |
| 7 | +// |
| 8 | +// This test case is disabled on .NET Standard because it doesn't have all the |
| 9 | +// APIs we use. We could work around that, but .NET Core doesn't implement |
| 10 | +// domain creation, so it's not worth it. |
| 11 | +// |
| 12 | +// Unfortunately this means no continuous integration testing for this case. |
| 13 | +// |
| 14 | +#if !NETSTANDARD && !NETCOREAPP |
| 15 | +namespace Python.EmbeddingTest |
| 16 | +{ |
| 17 | + class TestDomainReload |
| 18 | + { |
| 19 | + /// <summary> |
| 20 | + /// Test that the python runtime can survive a C# domain reload without crashing. |
| 21 | + /// |
| 22 | + /// At the time this test was written, there was a very annoying |
| 23 | + /// seemingly random crash bug when integrating pythonnet into Unity. |
| 24 | + /// |
| 25 | + /// The repro steps that David Lassonde, Viktoria Kovecses and |
| 26 | + /// Benoit Hudson eventually worked out: |
| 27 | + /// 1. Write a HelloWorld.cs script that uses Python.Runtime to access |
| 28 | + /// some C# data from python: C# calls python, which calls C#. |
| 29 | + /// 2. Execute the script (e.g. make it a MenuItem and click it). |
| 30 | + /// 3. Touch HelloWorld.cs on disk, forcing Unity to recompile scripts. |
| 31 | + /// 4. Wait several seconds for Unity to be done recompiling and |
| 32 | + /// reloading the C# domain. |
| 33 | + /// 5. Make python run the gc (e.g. by calling gc.collect()). |
| 34 | + /// |
| 35 | + /// The reason: |
| 36 | + /// A. In step 2, Python.Runtime registers a bunch of new types with |
| 37 | + /// their tp_traverse slot pointing to managed code, and allocates |
| 38 | + /// some objects of those types. |
| 39 | + /// B. In step 4, Unity unloads the C# domain. That frees the managed |
| 40 | + /// code. But at the time of the crash investigation, pythonnet |
| 41 | + /// leaked the python side of the objects allocated in step 1. |
| 42 | + /// C. In step 5, python sees some pythonnet objects in its gc list of |
| 43 | + /// potentially-leaked objects. It calls tp_traverse on those objects. |
| 44 | + /// But tp_traverse was freed in step 3 => CRASH. |
| 45 | + /// |
| 46 | + /// This test distills what's going on without needing Unity around (we'd see |
| 47 | + /// similar behaviour if we were using pythonnet on a .NET web server that did |
| 48 | + /// a hot reload). |
| 49 | + /// </summary> |
| 50 | + [Test] |
| 51 | + public static void DomainReloadAndGC() |
| 52 | + { |
| 53 | + // We're set up to run in the directory that includes the bin directory. |
| 54 | + System.IO.Directory.SetCurrentDirectory(AppDomain.CurrentDomain.BaseDirectory); |
| 55 | + |
| 56 | + Assembly pythonRunner1 = BuildAssembly("test1"); |
| 57 | + RunAssemblyAndUnload(pythonRunner1, "test1"); |
| 58 | + |
| 59 | + // Verify that python is not initialized even though we ran it. |
| 60 | + Assert.That(Runtime.Runtime.Py_IsInitialized(), Is.Zero); |
| 61 | + |
| 62 | + // This caused a crash because objects allocated in pythonRunner1 |
| 63 | + // still existed in memory, but the code to do python GC on those |
| 64 | + // objects is gone. |
| 65 | + Assembly pythonRunner2 = BuildAssembly("test2"); |
| 66 | + RunAssemblyAndUnload(pythonRunner2, "test2"); |
| 67 | + } |
| 68 | + |
| 69 | + // |
| 70 | + // The code we'll test. All that really matters is |
| 71 | + // using GIL { Python.Exec(pyScript); } |
| 72 | + // but the rest is useful for debugging. |
| 73 | + // |
| 74 | + // What matters in the python code is gc.collect and clr.AddReference. |
| 75 | + // |
| 76 | + // Note that the language version is 2.0, so no $"foo{bar}" syntax. |
| 77 | + // |
| 78 | + const string TestCode = @" |
| 79 | + using Python.Runtime; |
| 80 | + using System; |
| 81 | + class PythonRunner { |
| 82 | + public static void RunPython() { |
| 83 | + AppDomain.CurrentDomain.DomainUnload += OnDomainUnload; |
| 84 | + string name = AppDomain.CurrentDomain.FriendlyName; |
| 85 | + Console.WriteLine(string.Format(""[{0} in .NET] In PythonRunner.RunPython"", name)); |
| 86 | + using (Py.GIL()) { |
| 87 | + try { |
| 88 | + var pyScript = string.Format(""import clr\n"" |
| 89 | + + ""print('[{0} in python] imported clr')\n"" |
| 90 | + + ""clr.AddReference('System')\n"" |
| 91 | + + ""print('[{0} in python] allocated a clr object')\n"" |
| 92 | + + ""import gc\n"" |
| 93 | + + ""gc.collect()\n"" |
| 94 | +
F438
+ ""print('[{0} in python] collected garbage')\n"", |
| 95 | + name); |
| 96 | + PythonEngine.Exec(pyScript); |
| 97 | + } catch(Exception e) { |
| 98 | + Console.WriteLine(string.Format(""[{0} in .NET] Caught exception: {1}"", name, e)); |
| 99 | + } |
| 100 | + } |
| 101 | + } |
| 102 | + static void OnDomainUnload(object sender, EventArgs e) { |
| 103 | + System.Console.WriteLine(string.Format(""[{0} in .NET] unloading"", AppDomain.CurrentDomain.FriendlyName)); |
| 104 | + } |
| 105 | + }"; |
| 106 | + |
| 107 | + |
| 108 | + /// <summary> |
| 109 | + /// Build an assembly out of the source code above. |
| 110 | + /// |
| 111 | + /// This creates a file <paramref name="assemblyName"/>.dll in order |
| 112 | + /// to support the statement "proxy.theAssembly = assembly" below. |
| 113 | + /// That statement needs a file, can't run via memory. |
| 114 | + /// </summary> |
| 115 | + static Assembly BuildAssembly(string assemblyName) |
| 116 | + { |
| 117 | + var provider = CodeDomProvider.CreateProvider("CSharp"); |
| 118 | + |
| 119 | + var compilerparams = new CompilerParameters(); |
| 120 | + compilerparams.ReferencedAssemblies.Add("Python.Runtime.dll"); |
| 121 | + compilerparams.GenerateExecutable = false; |
| 122 | + compilerparams.GenerateInMemory = false; |
| 123 | + compilerparams.IncludeDebugInformation = false; |
| 124 | + compilerparams.OutputAssembly = assemblyName; |
| 125 | + |
| 126 | + var results = provider.CompileAssemblyFromSource(compilerparams, TestCode); |
| 127 | + if (results.Errors.HasErrors) |
| 128 | + { |
| 129 | + var errors = new System.Text.StringBuilder("Compiler Errors:\n"); |
| 130 | + foreach (CompilerError error in results.Errors) |
| 131 | + { |
| 132 | + errors.AppendFormat("Line {0},{1}\t: {2}\n", |
| 133 | + error.Line, error.Column, error.ErrorText); |
| 134 | + } |
| 135 | + throw new Exception(errors.ToString()); |
| 136 | + } |
| 137 | + else |
| 138 | + { |
| 139 | + return results.CompiledAssembly; |
| 140 | + } |
| 141 | + } |
| 142 | + |
| 143 | + /// <summary> |
| 144 | + /// This is a magic incantation required to run code in an application |
| 145 | + /// domain other than the current one. |
| 146 | + /// </summary> |
| 147 | + class Proxy : MarshalByRefObject |
| 148 | + { |
| 149 | + Assembly theAssembly = null; |
| 150 | + |
| 151 | + public void InitAssembly(string assemblyPath) |
| 152 | + { |
| 153 | + theAssembly = Assembly.LoadFile(System.IO.Path.GetFullPath(assemblyPath)); |
| 154 | + } |
| 155 | + |
| 156 | + public void RunPython() |
| 157 | + { |
| 158 | + Console.WriteLine("[Proxy] Entering RunPython"); |
| 159 | + |
| 160 | + // Call into the new assembly. Will execute Python code |
| 161 | + var pythonrunner = theAssembly.GetType("PythonRunner"); |
| 162 | + var runPythonMethod = pythonrunner.GetMethod("RunPython"); |
| 163 | + runPythonMethod.Invoke(null, new object[] { }); |
| 164 | + |
| 165 | + Console.WriteLine("[Proxy] Leaving RunPython"); |
| 166 | + } |
| 167 | + } |
| 168 | + |
| 169 | + /// <summary> |
| 170 | + /// Create a domain, run the assembly in it (the RunPython function), |
| 171 | + /// and unload the domain. |
| 172 | + /// </summary> |
| 173 | + static void RunAssemblyAndUnload(Assembly assembly, string assemblyName) |
| 174 | + { |
| 175 | + Console.WriteLine($"[Program.Main] === creating domain for assembly {assembly.FullName}"); |
| 176 | + |
| 177 | + // Create the domain. Make sure to set PrivateBinPath to a relative |
| 178 | + // path from the CWD (namely, 'bin'). |
| 179 | + // See https://stackoverflow.com/questions/24760543/createinstanceandunwrap-in-another-domain |
| 180 | + var currentDomain = AppDomain.CurrentDomain; |
| 181 | + var domainsetup = new AppDomainSetup() |
| 182 | + { |
| 183 | + ApplicationBase = currentDomain.SetupInformation.ApplicationBase, |
| 184 | + ConfigurationFile = currentDomain.SetupInformation.ConfigurationFile, |
| 185 | + LoaderOptimization = LoaderOptimization.SingleDomain, |
| 186 | + PrivateBinPath = "." |
| 187 | + }; |
| 188 | + var domain = AppDomain.CreateDomain( |
| 189 | + $"My Domain {assemblyName}", |
| 190 | + currentDomain.Evidence, |
| 191 | + domainsetup); |
| 192 | + |
| 193 | + // Create a Proxy object in the new domain, where we want the |
| 194 | + // assembly (and Python .NET) to reside |
| 195 | + Type type = typeof(Proxy); |
| 196 | + System.IO.Directory.SetCurrentDirectory(AppDomain.CurrentDomain.BaseDirectory); |
| 197 | + var theProxy = (Proxy)domain.CreateInstanceAndUnwrap( |
| 198 | + type.Assembly.FullName, |
| 199 | + type.FullName); |
| 200 | + |
| 201 | + // From now on use the Proxy to call into the new assembly |
| 202 | + theProxy.InitAssembly(assemblyName); |
| 203 | + theProxy.RunPython(); |
| 204 | + |
| 205 | + Console.WriteLine($"[Program.Main] Before Domain Unload on {assembly.FullName}"); |
| 206 | + AppDomain.Unload(domain); |
| 207 | + Console.WriteLine($"[Program.Main] After Domain Unload on {assembly.FullName}"); |
| 208 | + |
| 209 | + // Validate that the assembly does not exist anymore |
| 210 | + try |
| 211 | + { |
| 212 | + Console.WriteLine($"[Program.Main] The Proxy object is valid ({theProxy}). Unexpected domain unload behavior"); |
| 213 | + } |
| 214 | + catch (Exception) |
| 215 | + { |
| 216 | + Console.WriteLine("[Program.Main] The Proxy object is not valid anymore, domain unload complete."); |
| 217 | + } |
| 218 | + } |
| 219 | + |
| 220 | + /// <summary> |
| 221 | + /// Resolves the assembly. Why doesn't this just work normally? |
| 222 | + /// </summary> |
| 223 | + static Assembly ResolveAssembly(object sender, ResolveEventArgs args) |
| 224 | + { |
| 225 | + var loadedAssemblies = AppDomain.CurrentDomain.GetAssemblies(); |
| 226 | + |
| 227 | + foreach (var assembly in loadedAssemblies) |
| 228 | + { |
| 229 | + if (assembly.FullName == args.Name) |
| 230 | + { |
| 231 | + return assembly; |
| 232 | + } |
| 233 | + } |
| 234 | + |
| 235 | + return null; |
| 236 | + } |
| 237 | + } |
| 238 | +} |
| 239 | +#endif |
0 commit comments