Adds method name to "no method matches" error (#653)

AlexCatarino · filmor · commit 611814c3079a · 2018-07-16T15:12:47.000+02:00
diff --git a/AUTHORS.md b/AUTHORS.md
@@ -12,6 +12,7 @@
 
 ## Contributors
 
+-   Alexandre Catarino([@AlexCatarino](https://github.com/AlexCatarino))
 -   Arvid JB ([@ArvidJB](https://github.com/ArvidJB))
 -   Bradley Friedman ([@leith-bartrich](https://github.com/leith-bartrich))
 -   Callum Noble ([@callumnoble](https://github.com/callumnoble))
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -92,6 +92,7 @@ This document follows the conventions laid out in [Keep a CHANGELOG][].
 -   Fixed `Python.Runtime.dll.config` on macOS ([#120][i120])
 -   Fixed crash on `PythonEngine.Version` ([#413][i413])
 -   Fixed `PythonEngine.PythonPath` issues ([#179][i179])([#414][i414])([#415][p415])
+-   Fixed missing information on 'No method matches given arguments' by adding the method name
 
 ### Removed
 
diff --git a/src/runtime/methodbinder.cs b/src/runtime/methodbinder.cs
@@ -507,7 +507,12 @@ internal virtual IntPtr Invoke(IntPtr inst, IntPtr args, IntPtr kw, MethodBase i
 
             if (binding == null)
             {
-                Exceptions.SetError(Exceptions.TypeError, "No method matches given arguments");
+                var value = "No method matches given arguments";
+                if (methodinfo != null && methodinfo.Length > 0)
+                {
+                    value += $" for {methodinfo[0].Name}";
+                }
+                Exceptions.SetError(Exceptions.TypeError, value);
                 return IntPtr.Zero;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -507,7 +507,12 @@ internal virtual IntPtr Invoke(IntPtr inst, IntPtr args, IntPtr kw, MethodBase i`
`507`	`507`
`508`	`508`	`if (binding == null)`
`509`	`509`	`{`
`510`		`- Exceptions.SetError(Exceptions.TypeError, "No method matches given arguments");`
	`510`	`+ var value = "No method matches given arguments";`
	`511`	`+ if (methodinfo != null && methodinfo.Length > 0)`
	`512`	`+ {`
	`513`	`+ value += $" for {methodinfo[0].Name}";`
	`514`	`+ }`
	`515`	`+ Exceptions.SetError(Exceptions.TypeError, value);`
`511`	`516`	`return IntPtr.Zero;`
`512`	`517`	`}`
`513`	`518`