Fix OverflowException on 64bit due to bad cast

vmuriart · vmuriart · commit 5ad1e7ee57ab · 2017-02-14T22:01:15.000-07:00
Error message was `OverflowException occurred. Arithmetic operation resulted in an overflow.` Link below explains in more detail the issue. This fixes the issue in both 32/64bit. https://www.codeproject.com/Answers/899343/How-to-fix-OverflowException-occurred-Arithmetic-o#answer2
diff --git a/src/runtime/managedtype.cs b/src/runtime/managedtype.cs
@@ -28,7 +28,7 @@ internal static ManagedType GetManagedObject(IntPtr ob)
                     tp = ob;
                 }
 
-                var flags = (int)Marshal.ReadIntPtr(tp, TypeOffset.tp_flags);
+                var flags = (Int64)Marshal.ReadIntPtr(tp, TypeOffset.tp_flags);
                 if ((flags & TypeFlags.Managed) != 0)
                 {
                     IntPtr op = tp == ob
@@ -63,7 +63,7 @@ internal static bool IsManagedType(IntPtr ob)
                     tp = ob;
                 }
 
-                var flags = (int)Marshal.ReadIntPtr(tp, TypeOffset.tp_flags);
+                var flags = (Int64)Marshal.ReadIntPtr(tp, TypeOffset.tp_flags);
                 if ((flags & TypeFlags.Managed) != 0)
                 {
                     return true;

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ internal static ManagedType GetManagedObject(IntPtr ob)`
`28`	`28`	`tp = ob;`
`29`	`29`	`}`
`30`	`30`
`31`		`- var flags = (int)Marshal.ReadIntPtr(tp, TypeOffset.tp_flags);`
	`31`	`+ var flags = (Int64)Marshal.ReadIntPtr(tp, TypeOffset.tp_flags);`
`32`	`32`	`if ((flags & TypeFlags.Managed) != 0)`
`33`	`33`	`{`
`34`	`34`	`IntPtr op = tp == ob`
`@@ -63,7 +63,7 @@ internal static bool IsManagedType(IntPtr ob)`
`63`	`63`	`tp = ob;`
`64`	`64`	`}`
`65`	`65`
`66`		`- var flags = (int)Marshal.ReadIntPtr(tp, TypeOffset.tp_flags);`
	`66`	`+ var flags = (Int64)Marshal.ReadIntPtr(tp, TypeOffset.tp_flags);`
`67`	`67`	`if ((flags & TypeFlags.Managed) != 0)`
`68`	`68`	`{`
`69`	`69`	`return true;`