8000 Use unittest.skip(...) · pythonnet/pythonnet@4fcfc78 · GitHub
[go: up one dir, main page]
Skip to content

Commit 4fcfc78

Browse files
vmuriartvmuriart
committed
Use unittest.skip(...)
1 parent 1d9a226 commit 4fcfc78

File tree

4 files changed

+30
-21
lines changed

4 files changed

+30
-21
lines changed

‎src/tests/runtests.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@
4747
'test_thread',
4848
'test_docstring',
4949

50-
# FIXME: Fails due to unhandled exception
51-
# 'test_engine',
50+
# FIXME: Has tests that are being skipped.
51+
'test_engine',
5252

53-
# FIXME: Fails in Linux
53+
# FIXME: Randomly fails/passes on both Windows/Linux.
5454
# 'test_subclass',
5555
)
5656

‎src/tests/test_engine.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
# -*- coding: utf-8 -*-
2-
# FIXME: This test module fails due to unhandled exceptions
32

43
import sys
54
import unittest
@@ -20,12 +19,14 @@ def test_multiple_calls_to_initialize(self):
2019
except BaseException:
2120
self.fail("Initialize() raise an exception.")
2221

22+
@unittest.skip(reason="FIXME: test crashes")
2323
def test_import_module(self):
2424
"""Test module import."""
2525
m = PythonEngine.ImportModule("sys")
2626
n = m.GetAttr("__name__")
2727
self.assertTrue(n.AsManagedObject(System.String) == "sys")
2828

29+
@unittest.skip(reason="FIXME: test freezes")
2930
def test_run_string(self):
3031
"""Test the RunString method."""
3132
PythonEngine.AcquireLock()

‎src/tests/test_exceptions.py

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -307,23 +307,22 @@ def test_pickling_exceptions(self):
307307

308308
self.assertEqual(exc.args, loaded.args)
309309

310+
@unittest.skipIf(PY2, "__cause__ isn't implemented in PY2")
310311
def test_chained_exceptions(self):
311-
# __cause__ is py3 only
312-
if PY3:
313-
from Python.Test import ExceptionTest
314-
315-
try:
316-
ExceptionTest.ThrowChainedExceptions()
317-
except Exception as exc:
318-
msgs = ("Outer exception",
319-
"Inner exception",
320-
"Innermost exception",)
321-
for msg in msgs:
322-
self.assertEqual(exc.Message, msg)
323-
self.assertEqual(exc.__cause__, exc.InnerException)
324-
exc = exc.__cause__
325-
else:
326-
self.fail("Test should raise an exception")
312+
from Python.Test import ExceptionTest
313+
314+
try:
315+
ExceptionTest.ThrowChainedExceptions()
316+
except Exception as exc:
317+
msgs = ("Outer exception",
318+
"Inner exception",
319+
"Innermost exception",)
320+
for msg in msgs:
321+
self.assertEqual(exc.Message, msg)
322+
self.assertEqual(exc.__cause__, exc.InnerException)
323+
exc = exc.__cause__
324+
else:
325+
self.fail("Test should raise an exception")
327326

328327

329328
def test_suite():

‎src/tests/test_subclass.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# -*- coding: utf-8 -*-
2-
# FIXME: This test module fails on Linux
2+
# FIXME: This test module randomly passes/fails even if all tests are skipped.
3+
# Something fishy is going on with the Test fixtures. Behavior seen on CI on
4+
# both Linux and Windows
35

46
import unittest
57

@@ -66,9 +68,11 @@ def OnTestEvent(self, value):
6668
handler(self, args)
6769

6870

71+
@unittest.skip(reason="FIXME: test randomly pass/fails")
6972
class SubClassTests(unittest.TestCase):
7073
"""Test sub-classing managed types"""
7174

75+
@unittest.skip(reason="FIXME: test randomly pass/fails")
7276
def test_base_class(self):
7377
"""Test base class managed type"""
7478
ob = SubClassTest()
@@ -80,6 +84,7 @@ def test_base_class(self):
8084
self.assertEqual(list(ob.return_list()), ["a", "b", "c"])
8185
self.assertEqual(list(SubClassTest.test_list(ob)), ["a", "b", "c"])
8286

87+
@unittest.skip(reason="FIXME: test randomly pass/fails")
8388
def test_interface(self):
8489
"""Test python classes can derive from C# interfaces"""
8590
ob = InterfaceTestClass()
@@ -91,6 +96,7 @@ def test_interface(self):
9196
x = FunctionsTest.pass_through(ob)
9297
self.assertEqual(id(x), id(ob))
9398

99+
@unittest.skip(reason="FIXME: test randomly pass/fails")
94100
def test_derived_class(self):
95101
"""Test python class derived from managed type"""
96102
ob = DerivedClass()
@@ -107,6 +113,7 @@ def test_derived_class(self):
107113
x = FunctionsTest.pass_through(ob)
108114
self.assertEqual(id(x), id(ob))
109115

116+
@unittest.skip(reason="FIXME: test randomly pass/fails")
110117
def test_create_instance(self):
111118
"""Test derived instances can be created from managed code"""
112119
ob = FunctionsTest.create_instance(DerivedClass)
@@ -128,6 +135,7 @@ def test_create_instance(self):
128135
y = FunctionsTest.pass_through(ob2)
129136
self.assertEqual(id(y), id(ob2))
130137

138+
@unittest.skip(reason="FIXME: test randomly pass/fails")
131139
def test_events(self):
132140
class EventHandler(object):
133141
def handler(self, x, args):
@@ -150,6 +158,7 @@ def handler(self, x, args):
150158
self.assertEqual(event_handler.value, 3)
151159
self.assertEqual(len(d.event_handlers), 1)
152160

161+
@unittest.skip(reason="FIXME: test randomly pass/fails")
153162
def test_isinstance(self):
154163
a = [str(x) for x in range(0, 1000)]
155164
b = [System.String(x) for x in a]

0 commit comments

Comments
 (0)
0