Remove TODOS

BadSingleton · BadSingleton · commit 4ba50a77d841 · 2020-08-21T11:52:44.000-04:00
tp_clear and tp_traverse always return 0. No error check to do Addresses comments: #958 #958
diff --git a/src/runtime/managedtype.cs b/src/runtime/managedtype.cs
@@ -176,7 +176,6 @@ internal void CallTypeClear()
                 return;
             }
             var clearFunc = (Interop.InquiryFunc)Marshal.GetDelegateForFunctionPointer(clearPtr, typeof(Interop.InquiryFunc));
-            // TODO: Handle errors base on return value
             clearFunc(pyHandle);
         }
 
@@ -196,7 +195,6 @@ internal void CallTypeTraverse(Interop.ObjObjFunc visitproc, IntPtr arg)
             }
             var traverseFunc = (Interop.ObjObjArgFunc)Marshal.GetDelegateForFunctionPointer(traversePtr, typeof(Interop.ObjObjArgFunc));
             var visiPtr = Marshal.GetFunctionPointerForDelegate(visitproc);
-            // TODO: Handle errors base on return value
             traverseFunc(pyHandle, visiPtr, arg);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,6 @@ internal void CallTypeClear()`
`176`	`176`	`return;`
`177`	`177`	`}`
`178`	`178`	`var clearFunc = (Interop.InquiryFunc)Marshal.GetDelegateForFunctionPointer(clearPtr, typeof(Interop.InquiryFunc));`
`179`		`- // TODO: Handle errors base on return value`
`180`	`179`	`clearFunc(pyHandle);`
`181`	`180`	`}`
`182`	`181`
`@@ -196,7 +195,6 @@ internal void CallTypeTraverse(Interop.ObjObjFunc visitproc, IntPtr arg)`
`196`	`195`	`}`
`197`	`196`	`var traverseFunc = (Interop.ObjObjArgFunc)Marshal.GetDelegateForFunctionPointer(traversePtr, typeof(Interop.ObjObjArgFunc));`
`198`	`197`	`var visiPtr = Marshal.GetFunctionPointerForDelegate(visitproc);`
`199`		`- // TODO: Handle errors base on return value`
`200`	`198`	`traverseFunc(pyHandle, visiPtr, arg);`
`201`	`199`	`}`
`202`	`200`