8000 ENH: in verbose mode do not hide stderr of git rev-parse by yarikoptic · Pull Request #318 · python-versioneer/python-versioneer · GitHub
[go: up one dir, main page]
Skip to content

ENH: in verbose mode do not hide stderr of git rev-parse #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2022
Merged

ENH: in verbose mode do not hide stderr of git rev-parse #318

merged 1 commit into from
Aug 24, 2022

Conversation

yarikoptic
Copy link
Contributor

Hiding it made it very difficult to figure out why versionner was
failing to figure out the version.

Closes #310

@yarikoptic
ENH: in verbose mode do not hide stderr of git rev-parse
8dcde6e 
Hiding it made it very difficult to figure out why versionner was
failing to figure out the version.

Closes python-versioneer#310
@effigies
Copy link
Contributor

Should we add this to all runner() calls in this function?

@yarikoptic
Copy link
Contributor Author

Should we add this to all runner() calls in this function?

it seems that default is hide_stderr=False,

$> git grep 'def run_command'
src/git/from_vcs.py:def run_command(): pass  # --STRIP DURING BUILD
src/git/install.py:def run_command(): pass # --STRIP DURING BUILD
src/subprocess_helper.py:def run_command(commands, args, cwd=None, verbose=False, hide_stderr=False,

and there is no other overload to True so I do not see any other location to add this

$> git grep hide_stderr
src/git/from_vcs.py:                   hide_stderr=not verbose)
src/subprocess_helper.py:def run_command(commands, args, cwd=None, verbose=False, hide_stderr=False,
src/subprocess_helper.py:                                       stderr=(subprocess.PIPE if hide_stderr
test/git/test_git.py:                                 hide_stderr=False, env=None):

@effigies
Copy link
Contributor

Sounds good.

@effigies effigies merged commit 408adeb into python-versioneer:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pass stderr in verbose mode from running git commands?
2 participants
@yarikoptic @effigies
0