Switch selected uses of distutils to setuptools #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
effigies
reviewed
Jan 11, 2022
src/cmdclass.py
Outdated
| @@ -31,7 +31,7 @@ def get_cmdclass(cmdclass=None): | |||
| cmds = {} if cmdclass is None else cmdclass.copy() | |||
|
|
|||
| # we add "version" to both distutils and setuptools | |||
| from distutils.core import Command | |||
| from setuptools import Command | |||
There was a problem hiding this comment.
IIUC setuptools monkey-patches distutils.core? I think to maintain current behavior while bypassing the deprecation:
Suggested change
| from setuptools import Command | |
| try: | |
| from setuptools import Command | |
| except ImportError: | |
| from distutils.core import Command |
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| from distutils.core import setup | |||
| from setuptools import setup | |||
There was a problem hiding this comment.
This and the other is specifically a distutils test.
|
@effigies Review comments addressed. |
mslw
added a commit
to mslw/datalad-neuroimaging
that referenced
this pull request
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #275.
Note that this PR does not completely remove all uses of distutils:
distutils.command.build_scripts.build_scriptsintest/demoapp-script-only/setup.pyis kept, along with the reference todistutils.command.build_scriptsinINSTALL.md, as setuptools proper does not seem to have an equivalent class. You may want to ask on pypa/setuptools about the preferred way to update this import.