8000 updated comments · python-trio/flake8-async@a41f00b · GitHub
[go: up one dir, main page]

Skip to content

Commit a41f00b

Browse files
committed
updated comments
1 parent 8458fd5 commit a41f00b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

tests/test_flake8_trio.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,10 @@ def test_trio103_104(self):
113113
make_error(TRIO103, 47, 7),
114114
make_error(TRIO103, 52, 7),
115115
# nested exceptions
116-
make_error(TRIO104, 67, 8), # weird case, unsure if error
116+
make_error(TRIO104, 67, 8), # weird edge-case
117117
make_error(TRIO103, 61, 7),
118118
make_error(TRIO104, 92, 8),
119-
# make_error(TRIO104, 94, 8), # TODO: not implemented
119+
# make_error(TRIO104, 94, 8), # weird edge-case
120120
# bare except
121121
make_error(TRIO103, 97, 0),
122122
# multi-line

tests/trio103_104.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
except ValueError:
6565
raise e
6666
except:
67-
raise e # error?
67+
raise e # error: though sometimes okay
6868
except BaseException: # safe
6969
try:
7070
pass
@@ -91,7 +91,7 @@
9191
except ValueError as g:
9292
raise g # error
9393
except BaseException as h:
94-
raise h # error ?
94+
raise h # error? currently treated as safe
9595
raise e
9696
# bare except, equivalent to `except baseException`
9797
except: # error
@@ -145,7 +145,7 @@ def foo():
145145
return # error
146146

147147

148-
# TODO: don't avoid re-raise with continue/break
148+
# don't avoid re-raise with continue/break
149149
while True:
150150
try:
151151
pass

0 commit comments

Comments
 (0)
0