8000 Merge pull request #714 from a-tal/master · python-telegram-bot/urllib3@7d72ffc · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on May 21, 2023. It is now read-only.

Commit 7d72ffc

Browse files
committed
Merge pull request urllib3#714 from a-tal/master
allows user paths for ca_cert verify path
2 parents c752923 + 1fa9ec3 commit 7d72ffc

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

CONTRIBUTORS.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,9 @@ In chronological order:
172172
* Predrag Gruevski <https://github.com/obi1kenobi>
173173
* Made cert digest comparison use a constant-time algorithm.
174174

175+
* Adam Talsma <https://github.com/a-tal>
176+
* Bugfix to ca_cert file paths.
177+
175178
* [Your name or handle] <[email or website]>
176179
* [Brief summary of your changes]
177180

urllib3/connection.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import datetime
2+
import os
23
import sys
34
import socket
45
from socket import error as SocketError, timeout as SocketTimeout
@@ -205,10 +206,10 @@ def set_cert(self, key_file=None, cert_file=None,
205206
self.key_file = key_file
206207
self.cert_file = cert_file
207208
self.cert_reqs = cert_reqs
208-
self.ca_certs = ca_certs
209-
self.ca_cert_dir = ca_cert_dir
210209
self.assert_hostname = assert_hostname
211210
self.assert_fingerprint = assert_fingerprint
211+
self.ca_certs = ca_certs and os.path.expanduser(ca_certs)
212+
self.ca_cert_dir = ca_cert_dir and os.path.expanduser(ca_cert_dir)
212213

213214
def connect(self):
214215
# Add certificate verification

0 commit comments

Comments
 (0)
0