8000 Split Tests for Classes with Subclass-`de_json` · Issue #4652 · python-telegram-bot/python-telegram-bot · GitHub
[go: up one dir, main page]
Skip to content

Split Tests for Classes with Subclass-de_json #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8 of 16 tasks
Bibo-Joshi opened this issue Jan 15, 2025 · 0 comments · Fixed by #4654
Closed
8 of 16 tasks

Split Tests for Classes with Subclass-de_json #4652

Bibo-Joshi opened this issue Jan 15, 2025 · 0 comments · Fixed by #4654
Labels
🛠 refactor change type: refactor ⚙️ tests affected functionality: tests

Comments

@Bibo-Joshi
Copy link
Member
Bibo-Joshi commented Jan 15, 2025 •
edited
Loading

Basically #4593 for all other classes where de_json returns subclasses.
Doing this first will make #4635 easier for those classes.

Canditates

(all subclasse of TelegramObject that have subclasses on their own)
@Bibo-Joshi Bibo-Joshi added ⚙️ tests affected functionality: tests 🛠 refactor change type: refactor labels Jan 15, 2025
@Bibo-Joshi Bibo-Joshi mentioned this issue Jan 19, 2025
Merged
Bibo-Joshi added a commit that referenced this issue Feb 6, 2025
@Bibo-Joshi
Merge branch 'master' into chore/#4652-menubutton
8b2af36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🛠 refactor change type: refactor ⚙️ tests affected functionality: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Tests for TelegramObject Classes with Subclasses python-telegram-bot/python-telegram-bot
1 participant
@Bibo-Joshi
0