8000 Improve PyPI Automation · Issue #4373 · python-telegram-bot/python-telegram-bot · GitHub
[go: up one dir, main page]
Skip to content

Improve PyPI Automation #4373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bibo-Joshi opened this issue Jul 12, 2024 · 0 comments · Fixed by #4375
Closed

Improve PyPI Automation #4373

Bibo-Joshi opened this issue Jul 12, 2024 · 0 comments · Fixed by #4375
Assignees
@Bibo-Joshi
Labels
🔗 github-actions related technology: github-actions

Comments

@Bibo-Joshi
Copy link
Member

With v21.4 we've seen a first successfull application of the new automation introduced in #4364. However, while making the first release I've seen a few steps that can use improvement:

  • the tag still needs to be created manually. Moreover, it's currently created before the pypi release is there. If the pypi release fails and changes have to be made, the tag needs to be moved, which is not ideal
  • separation of test-pypi and pypi release are not working as I'd hoped: The tag-push currently also triggers the test-pypi release and since the compute-sigantures steps "needs" it, I have to manually approve/reject it before the signatures are created and the gh release is created

Even if it means some code duplication (which I'd originally tried to avoid by having everything in one workflow), I therefore will split the test-pypi and pypi flows in two separate workflows and set different triggers:

  • manual for test-pypi
  • for pypi either manual or maybe based on regex commit-message
@Bibo-Joshi Bibo-Joshi added the 🔗 github-actions related technology: github-actions label Jul 12, 2024
@Bibo-Joshi Bibo-Joshi self-assigned this Jul 12, 2024
@Bibo-Joshi Bibo-Joshi mentioned this issue Jul 13, 2024
Merged
5 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Bibo-Joshi Bibo-Joshi

Labels
🔗 github-actions related technology: github-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve PyPI Automation python-telegram-bot/python-telegram-bot
1 participant
@Bibo-Joshi
0