Handle Non-Message Updates in InvertedRole (#94)

DonutByte · web-flow · commit 0efef67235ae · 2023-08-12T00:20:50.000+02:00
* Added non-message tests for `InvertedRole`

* fix non-message updates not being handled
diff --git a/ptbcontrib/roles/roles.py b/ptbcontrib/roles/roles.py
@@ -396,6 +396,13 @@ def __init__(self, role: Role):
         super().__init__(name=f"<inverted {role}>", data_filter=False)
         self.role = role
 
+    def check_update(self, update: Update) -> bool:
+        """Check if the update is allowed by this role. This is just an alias for
+        :meth:`filter`.
+        """
+        # Override UpdateFilter.check_update to handle also updates that are not messages
+        return self.filter(update)
+
     def filter(self, update: Update) -> bool:
         """Checks if the update should be handled."""
         return self.role.filter(update, inverted=True)
diff --git a/tests/test_roles.py b/tests/test_roles.py
@@ -296,16 +296,19 @@ def test_always_allow_admin(self, update, role):
     def test_non_message_update(self, update, role):
         update.message = None
         assert not role.check_update(update)
+        assert not (~role).check_update(update)
 
         update.callback_query = CallbackQuery(
             id="id",
             from_user=User(id=0, is_bot=False, first_name="first_name"),
             chat_instance="chat_instance",
         )
         assert not role.check_update(update)
+        assert (~role).check_update(update)
 
         role.add_member(0)
         assert role.check_update(update)
+        assert not (~role).check_update(update)
 
     def test_pickle(self, role, parent_role):
         role.add_member([0, 1, 3])
