8000 Support registration in Consul · Issue #190 · python-microservices/pyms · GitHub
[go: up one dir, main page]

Skip to content

Support registration in Consul #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Agalin opened this issue Oct 12, 2020 · 2 comments · Fixed by #221
Closed

Support registration in Consul #190

Agalin opened this issue Oct 12, 2020 · 2 comments · Fixed by #221
Assignees

Comments

@Agalin
Copy link
Contributor
Agalin commented Oct 12, 2020

Is your feature request related to a problem? Please describe.
Would be nice to add support for registration in Consul. It can then be used as a configuration source for Prometheus for metrics scrapping. It's possible to configure manually now but standardized service would be an useful addition.

Consul can also be used as a service discovery (so would be a possible extension of requests integration as well) and key-value store (flask-consulate actually uses it as a configuration service).

Describe the solution you'd like
Add service that would wrap consulate package.

Describe alternatives you've considered
There is flask-consulate package that aims to provide some of the described functionality but it's barely maintained, provides no wheel binaries (it's messing with build process behind corporate proxy due to direct setup.py call) and some functions overlap with those that should be a part of pyms (it seems to retry service calls).

Additional context
There are other service discovery tools available, like Eureka or cloud-specific providers which means that it should be as provider-agnostic as possible, similar to tracing supporting two collection servers already.

@avara1986
Copy link
Member

Thanks @Agalin for your issues 😄 All your feature proposal are very interesting 👍

@Agalin
Copy link
Contributor Author
Agalin commented Oct 13, 2020

I'm just jealous of Spring Initializer where you can generate an app preconfigured for so many services... This project can be something similar for python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants
0