remove __check functions for validator model

abaez · abaez · commit a85c8ccd7bb1 · 2019-09-16T16:34:14.000-04:00
diff --git a/consulate/api/acl.py b/consulate/api/acl.py
@@ -3,7 +3,6 @@
 
 """
 import logging
-import json
 
 from consulate.models import acl as model
 from consulate.api import base
@@ -20,48 +19,6 @@
 # RoleLinks = List[RoleLink]
 
 
-def __check_policylinks(policies):
-    """ Checks if policies is formatted correctly.
-    :param list policies: A list of PolicyLink.
-    :param rtype: bool
-    :raises: consulate.exceptions.ACLFormatError
-
-    """
-    for policy in policies:
-        if not ('ID' in policy or 'Name' in policy):
-            raise exceptions.ACLPolicyFormatError(str(policy))
-
-    return True
-
-
-def __check_service_identities(service_identities):
-    """ Checks if service_identities is formatted correctly.
-    :param list service_identities: A ServiceIdentity list
-    :param rtype: bool
-    :raises: consulate.exceptions.ACLFormatError
-
-    """
-    for service_identity in service_identities:
-        if 'ServiceName' not in service_identity:
-            raise exceptions.ACLPolicyFormatError(str(service_identity))
-
-    return True
-
-
-def __create_json_format(structures, check):
-    """Creates a json string from a structures provided check passes.
-    :param list structure: a PolicyLinks or ServiceIdentities.
-    :param function check: a function to check structure
-    :param rtype: str
-
-    """
-    formatted = None
-    if structures is not None and check(structures):
-        formatted = json.dumps(structures)
-
-    return formatted
-
-
 class ACL(base.Endpoint):
     """The ACL endpoints are used to create, update, destroy, and query ACL
     tokens.
@@ -176,10 +133,6 @@ def create_role(self,
         :param rtype: dict
 
         """
-        policies = __create_json_format(policies, __check_policylinks)
-        service_identities = __create_json_format(service_identities,
-                                                  __check_service_identities)
-
         return self._put_response_body(
             ["role"], {},
             dict(
@@ -203,9 +156,6 @@ def update_role(self,
         :param rtype: dict
 
         """
-        policies = __create_json_format(policies, __check_policylinks)
-        service_identities = __create_json_format(service_identities,
-                                                  __check_service_identities)
         return self._put_response_body(
             ["role", id], {},
             dict(
