8000 1.2.4: minor test failures · Issue #109 · python-lsp/python-lsp-server · GitHub
[go: up one dir, main page]
Skip to content
8000

1.2.4: minor test failures #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0-wiz-0 opened this issue Nov 5, 2021 · 2 comments
Open

1.2.4: minor test failures #109

0-wiz-0 opened this issue Nov 5, 2021 · 2 comments

Comments

@0-wiz-0
Copy link
Contributor
0-wiz-0 commented Nov 5, 2021

I've just packaged python-lsp-server for pkgsrc. Running the self tests, I see a couple "failed" tests:

FAILED test/plugins/test_flake8_lint.py::test_flake8_unsaved - FileNotFoundError: [Errno 2] No such file or directory: 'python'
FAILED test/plugins/test_flake8_lint.py::test_flake8_lint - FileNotFoundError: [Errno 2] No such file or directory: 'python'
FAILED test/plugins/test_flake8_lint.py::test_flake8_per_file_ignores - FileNotFoundError: [Errno 2] No such file or directory: 'python'
FAILED test/plugins/test_pylint_lint.py::test_pylint - FileNotFoundError: [Errno 2] No such file or directory: 'python'
FAILED test/plugins/test_pylint_lint.py::test_syntax_error_pylint_py3 - FileNotFoundError: [Errno 2] No such file or directory: 'python'
FAILED test/plugins/test_pylint_lint.py::test_lint_free_pylint - AssertionError: assert not [{'code': 'W1514', 'message': '[unspecified-encoding] Using open without explicitly s...
FAILED test/plugins/test_pylint_lint.py::test_per_file_caching - AssertionError: assert not [{'code': 'W1514', 'message': '[unspecified-encoding] Using open without explicitly s...

The first five of these assume a "python" binary, which pkgsrc does not provide by default.
I'm not sure about the last two.
@ccordoba12
Copy link
Member

Hey @0-wiz-0, thanks for reporting. Tests are passing in our CIs, so if you want to make them pass in your system, please submit a pull request to that effect.

@0-wiz-0
Copy link
Contributor Author
0-wiz-0 commented Nov 5, 2021

#111 fixes the first three of the problems.
The next two are caused by calling 'pylint' but only 'pylint-3.9' is available. I don't have a good portable fix for that.

For the remaining two, I suggest running the tests in an ASCII environment (C locale), and I guess you'll see the same error there.

@ccordoba12 ccordoba12 mentioned this issue Nov 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ccordoba12 @0-wiz-0
0