Do not hide unexpected errors from pyflakes (#371)

muffinmad · gatesn · commit b00c5284cdbb · 2018-06-29T13:59:48.000+02:00
* Do not hide unexpected errors from pyflakes

Pyflake's api can report source decoding error throught unexpectedError. If these errors are hidden then it's hard to say if linter is enabled and working.

* Underscored unused variable
diff --git a/pyls/plugins/pyflakes_lint.py b/pyls/plugins/pyflakes_lint.py
@@ -31,8 +31,17 @@ def __init__(self, lines):
         self.lines = lines
         self.diagnostics = []
 
-    def unexpectedError(self, filename, msg):  # pragma: no cover
-        pass
+    def unexpectedError(self, _filename, msg):  # pragma: no cover
+        err_range = {
+            'start': {'line': 0, 'character': 0},
+            'end': {'line': 0, 'character': 0},
+        }
+        self.diagnostics.append({
+            'source': 'pyflakes',
+            'range': err_range,
+            'message': msg,
+            'severity': lsp.DiagnosticSeverity.Error,
+        })
 
     def syntaxError(self, _filename, msg, lineno, offset, text):
         # We've seen that lineno and offset can sometimes be None
