Prevent third-party plugins with faulty hooks to crash the server

ccordoba12 · ccordoba12 · commit 85a3e31a732a · 2022-02-01T13:03:09.000-05:00
diff --git a/pylsp/config/config.py b/pylsp/config/config.py
@@ -16,6 +16,17 @@
 DEFAULT_CONFIG_SOURCES = ['pycodestyle']
 
 
+class PluginManager(pluggy.PluginManager):
+
+    def _hookexec(self, hook, methods, kwargs):
+        # Prevent faulty hooks to crash the server
+        try:
+            return self._inner_hookexec(hook, methods, kwargs)
+        except Exception as e:  # pylint: disable=broad-except
+            log.warning(f"Failed to load hook {hook}: {e}")
+            return []
+
+
 class Config:
     def __init__(self, root_uri, init_opts, process_id, capabilities):
         self._root_path = uris.to_fs_path(root_uri)
@@ -39,7 +50,7 @@ def __init__(self, root_uri, init_opts, process_id, capabilities):
         except ImportError:
             pass
 
-        self._pm = pluggy.PluginManager(PYLSP)
+        self._pm = PluginManager(PYLSP)
         self._pm.trace.root.setwriter(log.debug)
         self._pm.enable_tracing()
         self._pm.add_hookspecs(hookspecs)
