Fix pycodestyle iterable options (#220)

gatesn · web-flow · commit 166967b591bb · 2018-01-14T11:33:07.000Z
* Fix pycodestyle iterable options

* Typo

* Typo
diff --git a/pyls/language_server.py b/pyls/language_server.py
@@ -65,7 +65,7 @@ def initialize(self, root_uri, init_opts, process_id):
         pass
 
     def m_initialize(self, **kwargs):
-        log.debug("Language server intialized with %s", kwargs)
+        log.debug("Language server initialized with %s", kwargs)
         if 'rootUri' in kwargs:
             self.root_uri = kwargs['rootUri']
         elif 'rootPath' in kwargs:
diff --git a/pyls/plugins/pycodestyle_lint.py b/pyls/plugins/pycodestyle_lint.py
@@ -12,12 +12,12 @@ def pyls_lint(config, document):
     log.debug("Got pycodestyle settings: %s", settings)
 
     opts = {
-        'exclude': settings.get('exclude'),
-        'filename': settings.get('filename'),
+        'exclude': ','.join(settings.get('exclude') or []),
+        'filename': ','.join(settings.get('filename') or []),
         'hang_closing': settings.get('hangClosing'),
-        'ignore': settings.get('ignore'),
+        'ignore': ','.join(settings.get('ignore') or []),
         'max_line_length': settings.get('maxLineLength'),
-        'select': settings.get('select'),
+        'select': ','.join(settings.get('select') or []),
     }
 
     styleguide = pycodestyle.StyleGuide({k: v for k, v in opts.items() if v is not None})
@@ -27,6 +27,7 @@ def pyls_lint(config, document):
     )
     c.check_all()
     diagnostics = c.report.diagnostics
+
     return diagnostics
 
 
diff --git a/test/plugins/test_pycodestyle_lint.py b/test/plugins/test_pycodestyle_lint.py
@@ -86,4 +86,9 @@ def test_pycodestyle_config(workspace):
     # And make sure we only get one warning
     diags = pycodestyle_lint.pyls_lint(config, doc)
     assert not [d for d in diags if d['code'] == 'W191']
-    assert [d for d in diags if d['code'] == 'W391']
+
+    # Ignore both warnings
+    config.update({'plugins': {'pycodestyle': {'ignore': ['W191', 'W391']}}})
+    # And make sure we get neither
+    assert not [d for d in diags if d['code'] == 'W191']
+    assert not [d for d in diags if d['code'] == 'W391']
