From c685764a986a37bbfa72a7c23b07b1d527d297b7 Mon Sep 17 00:00:00 2001 From: Teemu Rytilahti Date: Mon, 4 Mar 2024 18:55:44 +0100 Subject: [PATCH 1/2] Simplify device __repr__ --- kasa/device.py | 6 +----- kasa/tests/test_smartdevice.py | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/kasa/device.py b/kasa/device.py index cebec582c..63eafa5b7 100644 --- a/kasa/device.py +++ b/kasa/device.py @@ -366,8 +366,4 @@ async def set_alias(self, alias: str): def __repr__(self): if self._last_update is None: return f"<{self.device_type} at {self.host} - update() needed>" - return ( - f"<{self.device_type} model {self.model} at {self.host}" - f" ({self.alias}), is_on: {self.is_on}" - f" - dev specific: {self.state_information}>" - ) + return f"<{self.device_type} at {self.host} - {self.alias} ({self.model})>" diff --git a/kasa/tests/test_smartdevice.py b/kasa/tests/test_smartdevice.py index 92cca5a16..fdd342ca7 100644 --- a/kasa/tests/test_smartdevice.py +++ b/kasa/tests/test_smartdevice.py @@ -198,7 +198,7 @@ async def test_mac(dev): async def test_representation(dev): import re - pattern = re.compile("<.* model .* at .* (.*), is_on: .* - dev specific: .*>") + pattern = re.compile("") assert pattern.match(str(dev)) From 756244e6fe7c607c234e36e67bef1fab39624e9e Mon Sep 17 00:00:00 2001 From: Teemu Rytilahti Date: Mon, 4 Mar 2024 19:02:13 +0100 Subject: [PATCH 2/2] Show device type and model for child devices --- kasa/smart/smartchilddevice.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kasa/smart/smartchilddevice.py b/kasa/smart/smartchilddevice.py index 6d7bfa587..1ea517aa6 100644 --- a/kasa/smart/smartchilddevice.py +++ b/kasa/smart/smartchilddevice.py @@ -56,4 +56,4 @@ def device_type(self) -> DeviceType: return dev_type def __repr__(self): - return f"" + return f"<{self.device_type} {self.alias} ({self.model}) of {self._parent}>"