Bulbs: allow specifying transition for state changes #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
transition
kwarg for all state changing methods.The values are in milliseconds, and limits of what values are accepted differ likely between devices, so there is no checks for that for now. This has only been tested using the brightness & turn on/off transitions on a KL60.
This is a WIP, as mypy does not like that the signature of
turn_on
andturn_off
differ, so this does not currently pass the tests and that needs to be investigated.This PR also changes the setters to return the response from the device, which can potentially be useful for downstream developers:
I wanted to push this up to give an example how to test the transitions, this is related to #69