8000 Add inactivity setting for the motion module by rytilahti · Pull Request #453 · python-kasa/python-kasa · GitHub
[go: up one dir, main page]

Skip to content

Add inactivity setting for the motion module #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2023

Conversation

rytilahti
Copy link
Member
@rytilahti rytilahti commented May 17, 2023

This allows obtaining and changing the inactivity timeout for motion detectors.

Per comment in #452, there is a default rule that reverts this back to 60s which needs to be deleted if you want to use this.

Closes #452

@rytilahti rytilahti added the enhancement New feature or request label May 17, 2023
rytilahti and others added 3 commits May 17, 2023 20:04
@rytilahti rytilahti force-pushed the feat/pir_inactivity branch from 6f4fa65 to e3484c3 Compare May 17, 2023 18:04
@codecov-commenter
Copy link
codecov-commenter commented May 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@ce5821a). Click here to learn what that means.
Patch coverage: 60.00% of modified lines in pull request are covered.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #453   +/-   ##
=========================================
  Coverage          ?   79.39%           
=========================================
  Files             ?       25           
  Lines             ?     1902           
  Branches          ?      593           
=========================================
  Hits              ?     1510           
  Misses            ?      351           
  Partials          ?       41           
Impacted Files Coverage Δ
kasa/modules/motion.py 65.62% <60.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rytilahti rytilahti merged commit 18ce40b into python-kasa:master May 17, 2023
@rytilahti rytilahti deleted the feat/pir_inactivity branch May 17, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add set_cold_time to Motion module
3 participants
0