8000 Do not send light_on value to iot bulb set_state by sdb9696 · Pull Request #1090 · python-kasa/python-kasa · GitHub
[go: up one dir, main page]
Skip to content

Do not send light_on value to iot bulb set_state #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2024
Merged

Do not send light_on value to iot bulb set_state #1090

merged 3 commits into from
Jul 31, 2024

Conversation

sdb9696
Copy link
Collaborator
@sdb9696 sdb9696 commented Jul 30, 2024 •
edited
Loading

Passing this extra value causes the ignore_default check in the IotBulb._set_light_state method to fail which causes the device to come back on to the default state.

        # If we are turning on without any color mode flags,
        # we do not want to set ignore_default to ensure
        # we restore the previous state.
        if state["on_off"] and NON_COLOR_MODE_FLAGS.issuperset(state):
            state["ignore_default"] = 0

Should fix some of the issues report in HA Issue 122220

@codecov Codecov
Copy link
codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (7bba992) to head (85be2ac).
Report is 88 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1090   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          96       96           
  Lines        6067     6069    +2     
  Branches     1495     1495           
=======================================
+ Hits         5611     5613    +2     
  Misses        354      354           
  Partials      102      102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti
Copy link
Member

Does this fix #1066?

@sdb9696
Copy link
Collaborator Author
sdb9696 commented Jul 30, 2024

Does this fix #1066?

I don’t think so but I will test it out.

@sdb9696 sdb9696 merged commit cb0077f into master Jul 31, 2024
25 checks passed
@sdb9696 sdb9696 deleted the fix/light_ignore_default branch July 31, 2024 14:56
@sdb9696 sdb9696 added the bug Something isn't working label Jul 31, 2024
@sdb9696 sdb9696 added this to the 0.7.1 milestone Jul 31, 2024
@sdb9696 sdb9696 mentioned this pull request Jul 31, 2024
Merged
sdb9696 added a commit that referenced this pull request Jul 31, 2024
@sdb9696
Prepare 0.7.1 (#1094)
145a16d 
## [0.7.1](https://github.com/python-kasa/python-kasa/tree/0.7.1) (2024-07-31)

[Full Changelog](0.7.0.5...0.7.1)

**Release highlights:**
- This release consists mainly of bugfixes and project improvements.
- There is also new support for Tapo T100 motion sensors.
- The CLI now supports child devices on all applicable commands.

**Implemented enhancements:**

- Expose reboot action [\#1073](#1073) (@rytilahti)
- Decrypt KLAP data from PCAP files [\#1041](#1041) (@clstrickland)
- Support child devices in all applicable cli commands [\#1020](#1020) (@sdb9696)

**Fixed bugs:**

- Fix iot light effect brightness [\#1092](#1092) (@sdb9696)
- Enable setting brightness with color temp for smart devices [\#1091](#1091) (@sdb9696)
- Do not send light\_on value to iot bulb set\_state [\#1090](#1090) (@sdb9696)
- Allow erroring modules to recover [\#1080](#1080) (@sdb9696)
- Raise KasaException on decryption errors [\#1078](#1078) (@sdb9696)
- Update smart request parameter handling [\#1061](#1061) (@sdb9696)
- Fix light preset module when list contains lighting effects [\#1048](#1048) (@sdb9696)
- Handle module errors more robustly and add query params to light preset and transition [\#1036](#1036) (@sdb9696)
- Fix credential hash to return None on empty credentials [\#1029](#1029) (@sdb9696)

**Added support for devices:**

- Add support for T100 motion sensor [\#1079](#1079) (@rytilahti)

**Project maintenance:**

- Bump project version to 0.7.0.5 [\#1087](#1087) (@sdb9696)
- Fix generate\_supported pre commit to run in venv [\#1085](#1085) (@sdb9696)
- Fix intermittently failing decryption error test [\#1082](#1082) (@sdb9696)
- Fix mypy pre-commit hook on windows [\#1081](#1081) (@sdb9696)
- Update RELEASING.md for patch releases [\#1076](#1076) (@sdb9696)
- Use monotonic time for query timing [\#1070](#1070) (@sdb9696)
- Fix parse\_pcap\_klap on windows and support default credentials [\#1068](#1068) (@sdb9696)
- Add fixture file for KP405 fw 1.0.6 [\#1063](#1063) (@daleye)
- Bump project version to 0.7.0.3 [\#1053](#1053) (@sdb9696)
- Add KP400\(US\) v1.0.4 fixture [\#1051](#1051) (@gimpy88)
- Add new HS220 kasa aes fixture [\#1050](#1050) (@sdb9696)
- Add KS205\(US\) v1.1.0 fixture [\#1049](#1049) (@gimpy88)
- Add KS200M\(US\) v1.0.11 fixture [\#1047](#1047) (@sdb9696)
- Add KS225\(US\) v1.1.0 fixture [\#1046](#1046) (@sdb9696)
- Split out main cli module into lazily loaded submodules [\#1039](#1039) (@sdb9696)
- Structure cli into a package [\#1038](#1038) (@sdb9696)
- Add KP400 v1.0.3 fixture [\#1037](#1037) (@gimpy88)
- Add L920\(EU\) v1.1.3 fixture [\#1031](#1031) (@rytilahti)
- Update changelog generator config [\#1030](#1030) (@sdb9696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sdb9696 @rytilahti
0