Make calling update on child devices consistent and give control over whether to update the parent #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1021 +/- ##
==========================================
+ Coverage 92.03% 92.05% +0.02%
==========================================
Files 84 84
Lines 5798 5828 +30
Branches 1400 1409 +9
==========================================
+ Hits 5336 5365 +29
- Misses 356 358 +2
+ Partials 106 105 -1 ☔ View full report in Codecov by Sentry. |
|
Marking as draft for now as need to think a bit more about the HA side of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is normalising the behaviour of
updateacrossiotandsmartdevices such that:updatecan be called by consumers on child devices without them being surprised that it is a noop or partial for some devices and not for others.update_children(renamedupdate_children_or_parent) has the same default value ofTrueacross devices.smartdevices don't callupdateon children ifupdate_children_or_parentisFalse.update_children_or_parent=Falseso they just update their own module queries.update_childrenas a kwarg retain the same behaviour and get a deprecation warning. (i.e.smartignores the parameter and always updates children)Currently Hubs do not support updates on children directly but this could be a good feature to implement in another PR to allow finer grained control for hubs with many attached devices.
Not to be merged until we're finished with 0.7.0.x patches