8000 Docs: Smart Strip - Emeter feature Note · Issue #257 · python-kasa/python-kasa · GitHub
[go: up one dir, main page]
Skip to content

Docs: Smart Strip - Emeter feature Note #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maxprehl opened this issue Nov 22, 2021 · 3 comments · Fixed by #333
Closed

Docs: Smart Strip - Emeter feature Note #257

maxprehl opened this issue Nov 22, 2021 · 3 comments · Fixed by #333
Labels
documentation Improvements or additions to documentation

Comments

@maxprehl
Copy link

At the top of the Smart Strips docs page (source) there's a note that says the Emeter feature is not implemented, and links to this issue #64.

Note
The emeter feature is currently not implemented for smart strips. See #64 for details.

After looking through the issue, it looks like there was a successful PR #203 to add support.

If so, can this note be removed?

Also are there any other updates to make to this docs page regarding the feature?
@rytilahti
Copy link
Member

Hi, yes, that note can be removed. Do you mind creating a PR to update the documentation on that? To your second question, there may also be other instances where the docs are outdated, in fact it's quite likely. If you spot any outdated docs, feel free to create a PR to get it fixed :-)

@rytilahti rytilahti added the documentation Improvements or additions to documentation label Nov 23, 2021
@allandaly
Copy link

I just created a PR for this change.

@rytilahti
Copy link
Member

@allandaly mind linking the PR number as I'm not finding it?

@rytilahti rytilahti mentioned this issue Apr 5, 2022
Merged
@rytilahti rytilahti mentioned this issue Apr 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various documentation updates rytilahti/python-kasa
3 participants
@allandaly @rytilahti @maxprehl
0