Do not pass None as timeout to http requests (#1203)

sdb9696 · web-flow · commit b82743a5debc · 2024-10-29T11:52:53.000Z
diff --git a/kasa/experimental/sslaestransport.py b/kasa/experimental/sslaestransport.py
@@ -97,9 +97,6 @@ def __init__(
         self._default_credentials: Credentials = get_default_credentials(
             DEFAULT_CREDENTIALS["TAPOCAMERA"]
         )
-
-        if not config.timeout:
-            config.timeout = self.DEFAULT_TIMEOUT
         self._http_client: HttpClient = HttpClient(config)
 
         self._state = TransportState.HANDSHAKE_REQUIRED
diff --git a/kasa/httpclient.py b/kasa/httpclient.py
@@ -89,6 +89,8 @@ async def post(
         self._last_url = url
         self.client.cookie_jar.clear()
         return_json = bool(json)
+        if self._config.timeout is None:
+            _LOGGER.warning("Request timeout is set to None.")
         client_timeout = aiohttp.ClientTimeout(total=self._config.timeout)
 
         # If json is not a dict send as data.
diff --git a/kasa/protocol.py b/kasa/protocol.py
@@ -91,7 +91,9 @@ def __init__(
         self._port = config.port_override or self.default_port
         self._credentials = config.credentials
         self._credentials_hash = config.credentials_hash
-        self._timeout = config.timeout or self.DEFAULT_TIMEOUT
+        if not config.timeout:
+            config.timeout = self.DEFAULT_TIMEOUT
+        self._timeout = config.timeout
 
     @property
     @abstractmethod

Original file line number	Diff line number	Diff line change
`@@ -97,9 +97,6 @@ def __init__(`
`97`	`97`	`self._default_credentials: Credentials = get_default_credentials(`
`98`	`98`	`DEFAULT_CREDENTIALS["TAPOCAMERA"]`
`99`	`99`	`)`
`100`		`-`
`101`		`- if not config.timeout:`
`102`		`- config.timeout = self.DEFAULT_TIMEOUT`
`103`	`100`	`self._http_client: HttpClient = HttpClient(config)`
`104`	`101`
`105`	`102`	`self._state = TransportState.HANDSHAKE_REQUIRED`