Make HSV NamedTuple creation more efficient (#1211)

sdb9696 · web-flow · commit 673a32258fb0 · 2024-10-29T17:14:52.000Z
diff --git a/kasa/iot/iotbulb.py b/kasa/iot/iotbulb.py
@@ -367,7 +367,9 @@ def _hsv(self) -> HSV:
         saturation = light_state["saturation"]
         value = self._brightness
 
-        return HSV(hue, saturation, value)
+        # Simple HSV(hue, saturation, value) is less efficent than below
+        # due to the cpython implementation.
+        return tuple.__new__(HSV, (hue, saturation, value))
 
     @requires_update
     async def _set_hsv(
diff --git a/kasa/smart/modules/color.py b/kasa/smart/modules/color.py
@@ -44,7 +44,9 @@ def hsv(self) -> HSV:
             self.data.get("brightness", 0),
         )
 
-        return HSV(hue=h, saturation=s, value=v)
+        # Simple HSV(h, s, v) is less efficent than below
+        # due to the cpython implementation.
+        return tuple.__new__(HSV, (h, s, v))
 
     def _raise_for_invalid_brightness(self, value):
         """Raise error on invalid brightness value."""

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,9 @@ def hsv(self) -> HSV:`
`44`	`44`	`self.data.get("brightness", 0),`
`45`	`45`	`)`
`46`	`46`
`47`		`- return HSV(hue=h, saturation=s, value=v)`
	`47`	`+ # Simple HSV(h, s, v) is less efficent than below`
	`48`	`+ # due to the cpython implementation.`
	`49`	`+ return tuple.__new__(HSV, (h, s, v))`
`48`	`50`
`49`	`51`	`def _raise_for_invalid_brightness(self, value):`
`50`	`52`	`"""Raise error on invalid brightness value."""`