Latest review comments

sdb9696 · sdb9696 · commit 43f5b8e0b760 · 2023-11-29T16:49:57.000Z
diff --git a/kasa/aesprotocol.py b/kasa/aesprotocol.py
@@ -51,9 +51,6 @@ class TPLinkAes(TPLinkProtocol):
 
     DEFAULT_PORT = 80
     DEFAULT_TIMEOUT = 5
-    DISCOVERY_QUERY = {"system": {"get_sysinfo": None}}
-    KASA_SETUP_EMAIL = "kasa@tp-link.net"
-    KASA_SETUP_PASSWORD = "kasaSetup"  # noqa: S105
     SESSION_COOKIE_NAME = "TP_SESSIONID"
     COMMON_HEADERS = {
         "Content-Type": "application/json",
@@ -304,6 +301,12 @@ async def _query(self, request: Union[str, Dict], retry_count: int = 3) -> Dict:
         raise SmartDeviceException("Query reached somehow to unreachable")
 
     async def _execute_query(self, request: Union[str, Dict], retry_count: int) -> Dict:
+        _LOGGER.debug(
+            "%s >> %s",
+            self.host,
+            _LOGGER.isEnabledFor(logging.DEBUG) and pf(request),
+        )
+
         if not self.http_client:
             self.http_client = httpx.AsyncClient()
 
diff --git a/kasa/tapo/tapodevice.py b/kasa/tapo/tapodevice.py
@@ -5,6 +5,7 @@
 from typing import Any, Dict, Optional, Set, cast
 
 from ..aesprotocol import TPLinkAes
+from ..credentials import Credentials
 from ..exceptions import AuthenticationException
 from ..smartdevice import SmartDevice
 
@@ -19,11 +20,10 @@ def __init__(
         host: str,
         *,
         port: Optional[int] = None,
-        credentials,
+        credentials: Optional[Credentials] = None,
         timeout: Optional[int] = None,
     ) -> None:
         super().__init__(host, port=port, credentials=credentials, timeout=timeout)
-        self._tapo_client = None
         self._state_information: Dict[str, Any] = {}
         self._discovery_info: Optional[Dict[str, Any]] = None
         self.protocol = TPLinkAes(host, credentials=credentials, timeout=timeout)
@@ -133,8 +133,6 @@ def state_information(self) -> Dict[str, Any]:
         return {
             "overheated": self._info.get("overheated"),
             "signal_level": self._info.get("signal_level"),
-            "auto_off_status": self._info.get("auto_off_status"),
-            "auto_off_remain_time": self._info.get("auto_off_remain_time"),
             "SSID": base64.b64decode(str(self._info.get("ssid"))).decode(),
         }
 
diff --git a/kasa/tapo/tapoplug.py b/kasa/tapo/tapoplug.py
@@ -3,6 +3,7 @@
 from datetime import datetime, timedelta
 from typing import Any, Dict, Optional, cast
 
+from ..credentials import Credentials
 from ..emeterstatus import EmeterStatus
 from ..smartdevice import DeviceType
 from .tapodevice import TapoDevice
@@ -18,7 +19,7 @@ def __init__(
         host: str,
         *,
         port: Optional[int] = None,
-        credentials,
+        credentials: Optional[Credentials] = None,
         timeout: Optional[int] = None,
     ) -> None:
         super().__init__(host, port=port, credentials=credentials, timeout=timeout)
