We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
test_project_push_rules
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the test_project_push_rules test work.
Sorry, something went wrong.
test: fix test_project_push_rules test
8779cf6
Make the `test_project_push_rules` test work.
fbc8436
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if raising GitlabParsingError is correct for a "valid" response, IIRC we added it for malformed responses and not for real GitLab responses (although here I would expect an empty dict or 404 TBH). Maybe a more specific error or an upstream fix to not return None would be clearer to users.
GitlabParsingError
Here is an old issue that I forgot about completely: #1192
And the upstream issue: https://gitlab.com/gitlab-org/gitlab/-/issues/8829
I doubt it is the correct but it is what we are currently doing. My goal was to fix the test at this stage, not to fix the underlying issue which I think will be harder to fix...
Here is an old issue that I forgot about completely: #1192 And the upstream issue: https://gitlab.com/gitlab-org/gitlab/-/issues/8829
Good info!
__init__
Makes sense, I just wanted to track that somewhere which was the purpose of the xfail. I've opened an issue for that :)
c676b43
nejch nejch approved these changes
Successfully merging this pull request may close these issues.