chore(test): prevent 'job_with_artifact' fixture running forever

JohnVillalovos · nejch · commit e4673d8aeaf9 · 2025-01-22T17:47:40.000+01:00
Previously the 'job_with_artifact' fixture could run forever. Now give
it up to 60 seconds to complete before failing.
diff --git a/tests/functional/cli/test_cli_artifacts.py b/tests/functional/cli/test_cli_artifacts.py
@@ -1,3 +1,4 @@
+import logging
 import subprocess
 import textwrap
 import time
@@ -24,12 +25,22 @@
 
 @pytest.fixture(scope="module")
 def job_with_artifacts(gitlab_runner, project):
+    start_time = time.time()
+
     project.files.create(data)
 
     jobs = None
     while not jobs:
         time.sleep(0.5)
         jobs = project.jobs.list(scope="success")
+        if time.time() - start_time < 60:
+            continue
+        logging.error("job never succeeded")
+        for job in project.jobs.list():
+            job = project.jobs.get(job.id)
+            logging.info(f"{job.status} job: {job.pformat()}")
+            logging.info(f"job log:\n{job.trace()}\n")
+        pytest.fail("Fixture 'job_with_artifact' failed")
 
     return project.jobs.get(jobs[0].id)
 
